Invalid marker content in wysiwyg_editor.module:37
* t('<p style="font-size:x-small">$Revision: 1.1.2.5 $ $Date: 2008/05/30 03:03:13 $</p>'.'<p>Wysiwyg Editor adds what-you-see-is-what-you-ge
t (WYSIWYG) html editing to textareas. This editor can be enabled/disabled without reloading the page by clicking a link below each textarea
.</p>
                <p>Profiles can be defined based on user roles. A Wysiwyg Editor profile can define which pages receive this Wysiwyg Editor
capability, what buttons or themes are enabled for the editor, how the editor is displayed, and a few other editor functions.</p>
                <p>Lastly, only users with the <code>access wysiwyg editor

permission will be able to use Wysiwyg
Editor.

',array('!url'=>url('admin/user/access')))

CommentFileSizeAuthor
#7 wysiwyg-DRUPAL-5.strings.patch10.96 KBsun
#5 wysiwyg-DRUPAL-5.strings.patch9.84 KBsun
#4 wysiwyg_help_D5_fix1.patch1.48 KBhass
#3 wysiwyg-DRUPAL-5.potx_.patch2.4 KBsun

Comments

hass’s picture

hass commented

And this in D6:

Invalid marker content in wysiwyg_editor.module:37
* t('<p style="font-size:x-small">$Revision: 1.4 $ $Date: 2008/05/30 03:03:01 $</p>'.'<p>Wysiwyg Editor adds what-you-see-is-what-you-get (W
YSIWYG) html editing to textareas. This editor can be enabled/disabled without reloading the page by clicking a link below each textarea.</p
>
                <p>Profiles can be defined based on user roles. A Wysiwyg Editor profile can define which pages receive this Wysiwyg Editor
capability, what buttons or themes are enabled for the editor, how the editor is displayed, and a few other editor functions.</p>
                <p>Lastly, only users with the access wysiwyg editor <a href="!url">permission</a> will be able to use Wysiwyg
Editor.</p>',array('!url'=>url('admin/user/access')))

Invalid menu 'title' definition found in wysiwyg_editor_menu() in wysiwyg_editor.module on line 18

Invalid menu 'description' definition found in wysiwyg_editor_menu() in wysiwyg_editor.module on line 20
hass’s picture

hass commented

See #192723: Invalid marker content in tinymce.module:34 for the patch staying in the queue for 6 months.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed
StatusFileSize
new wysiwyg-DRUPAL-5.potx_.patch2.4 KB

Thanks, committed attached patch.

hass’s picture

hass commented
Status: Fixed » Needs review
StatusFileSize
new wysiwyg_help_D5_fix1.patch1.48 KB

HTML code should avoided inside translatable strings if we are able to move it outside the t()... i cannot remember if I've done this wrong in my patch... 6 month ago :-(. And never make line breaks inside a t'ified strings.

New patch attached.

Aside TinyMCE was one of the modules i don't like very much about translatability. It would be good to do a string review and change some things like "false", "true" selectboxes to "yes", "no" or better - simple checkboxes for feature selection. This would be much better from usability side! The UI needs much work!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new wysiwyg-DRUPAL-5.strings.patch9.84 KB

Alex, I totally agree with you. However, converting false/true strings is a bit more complex, since TinyMCE expects boolean values (true/false) as *strings* (i.e. 'true') for its configuration. However, we can certainly change the displayed form values in the module settings.

As for HTML not allowed in t() strings - I've not yet heard of that and I know plenty of other modules that use HTML for longer texts, like in this case, output for hook_help. There are also more instances of HTML in t() strings in this module. If guidelines have been changed recently, can you point me to an informational resource where I can learn about that, please?

Besides that, attached patch can be tested independently.

hass’s picture

hass commented

Just take a look into D6 core hook_help's... I cannot remember if this is written somewhere in a handbook. I think not, but Gabor said it somewhere i cannot remember. Wherever you look you see surrounding HTML is moved outside - if possible.

Well all this changes looks much better then the old, but you shouldn't miss the descriptions... they often contains the words true or false... I'd like checkboxes MUCH more as it's save space and looks more like other core settings, etc.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new wysiwyg-DRUPAL-5.strings.patch10.96 KB

Thanks, I've updated hook_help() accordingly. There are some more instances, but I'm running out of time now. So if you want to, you can update this patch.

Changing the field types in admin settings is a good idea, but a different issue than this.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Were you able to test this patch? I would really like to commit it soon, but need at least one confirmation that it works.

hass’s picture

hass commented

Code wise the patch looks good, but i haven't tested it.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

So, be it. Committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.