CSV parsing fails when a comma is in the field

Well, that works, but I don't like the intermediate file thing. It is slow, and introduces concurrency issues.

Try this instead? http://php.net/manual/en/function.str-getcsv.php

Or something from comments there, or here http://www.php.net/manual/en/function.split.php

I fixed this bug without using a temporary file. It works on the assumption that commas that need to be escaped will always appear within a set of quotes. Insert the following code after (around line 107):

  if ($result->code != 200) {
    watchdog('stockapi', t('StockAPI: drupal_http_request code: @code', array('@code' => $result->code)));
    return FALSE;
  }

Insert this code:

  $data = $result->data;
  $data = explode(',', $data);
  
  $i = 0;
  while ($i < (count($data) - 1)) {
    $value = $data[$i];
    if ((substr($value, 0, 1) == '"') && (substr($value, strlen($value) - 1, 1)) != '"') {
      $data[$i] = $value . ',' . $data[$i+1];
      $data = array_merge(array_slice($data, 0, $i+1), array_slice($data, $i+2));
      $i = $i - 1;
    }
    else
      $data[$i] = str_replace('"', '', $value);
    $i++;
  }
  $data[$i] = str_replace('"', '', $data[$i]);

and before:

  if (!$data) {
    watchdog('stockapi', t('StockAPI: no data for symbol(s): @symbol', array('@symbol' => $symbol)));
    return FALSE;
  }

It should at least fix the problems for the yahoo feed.

Please submit a working patch for review. See http://drupal.org/patch for details on how to do so.

Here's a patch with the code from andywalters.

KC

Thank you for taking the time to create this.

I think that this code is a bit verbose and complicated. Can it be simplified as much of possible so it is maintainable and understandable going forward?

Here's an updated simplified version of the patch.

KC

Committed.

Thanks