Not much that I've changed so far but basic D6 compliance (so simple that I'm not sure there is much else to do). Against HEAD.

CommentFileSizeAuthor
#4 foundation_d6-upgrade_264861-4.patch18.99 KBadd1sun
#1 foundation_d6-upgrade_264861-1.patch2.29 KBadd1sun
foundation_d6-upgrade.patch2.23 KBadd1sun

Comments

add1sun’s picture

add1sun commented
Status: Active » Needs review
StatusFileSize
new foundation_d6-upgrade_264861-1.patch2.29 KB

Whoops - this one has the sidebars set right.

beginner’s picture

beginner commented

Is this theme still maintained?
Do you have commit rights?

add1sun’s picture

add1sun commented

I've no idea if it is maintained (certainly doesn't look it) and no, I don't have commit rights. I was just poking around at really simple starter themes and wanted to give this one a whirl. The "upgrade" was only a few lines so I figured I'd put up the patch.

If folks are interested and it is not maintained, I wouldn't mind asking for commit access and at least making a release.

add1sun’s picture

add1sun commented
StatusFileSize
new foundation_d6-upgrade_264861-4.patch18.99 KB

OK, this is a hella cleanup to pull things a bit more line with newer ways of doing things in Drupal. Things like using default variables (body_classes, left and right sidebars and search_box) and removing the label from the search box by overriding in template.php vs. insecurely going around the search form. Also added the new separate footer region (different from the footer_message now).

I also did some formatting changes, notably in the CSS so that whole file has changed and it isn't easy to see the "real" changes I made. But basically all I really changed was the class names dealing with the sidebars to use the core Drupal body_classes variable. I also removed the dashboard CSS rules since that isn't applicable at all. I am just making cleanups as I work so I do apologize for the formatting changes mixed in here too. I can try going back and redoing a patch later without the formatting changes but I don't know that I'll have time for it. :-/

add1sun’s picture

add1sun commented

coolio. rkerr gave me commit access so I'll roll up an official D5 release as well as a D6 upgrade, hopefully by sometime this weekend.

kbahey’s picture

kbahey commented

This is a simple theme that is a great starting point, and I use it often in projects.

Subscribing.

add1sun’s picture

add1sun commented
Status: Needs review » Fixed

Committed to HEAD. I'll make the dev snapshot available and then roll an official D6 release soon.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Project: Foundation »
Version: 6.x-1.x-dev »
Issue summary: View changes

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 2925308)