Custom logo not displayed
dirkels - May 31, 2008 - 10:52
| Project: | Artists C01 |
| Version: | 5.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
Hi. The custom logo does not display. Am I missing something obvious?
On theme config page; logo is enabled, default logo disabled and file path to logo is populated. Our image is png saved without transparency. Browser is Firefox.
Thanks
#1
Same problem here. No matter if I use explicit settings for artistsC01 only or the global settings. Core themes work. The standard logo works in artistsC01 as well.
I have the theme in a subdomain path like /sites/subdomain.example.com/themes while the files path is /sites/subdomain.example.com/files. I've verified that both the global and the theme-specific logo-files got uploaded there.
Looks like the
if (isset($logo))in line 37 in page.tpl.php<td><?php if (isset($logo)): ?> <?php print '<a href="' . check_url($base_path) . '" title="' . $site_name . '"><img src="'. check_url($logo) .'" alt="'. $site_name .'" id="logo" /></a>'; ?> <?php endif; ?></td>computes to FALSE, which leads to
...<table class="layout site-header">
<tbody>
<tr>
<-- logo-markup should be here -->
<td/>
<td class="align-top">
<table class="layout">
...
in the resulting HTML.
Without the
ifI get...<td>
<a title="Title" href="/">
<img id="logo" alt="Title" src=""/>
</a>
</td>
...
but now I'm lost.
#2
Attaching a patch (which also works against 5.x-1.3) to fix this issue. The bug was introduced with the last farbtastic fix. I don't think I broke anything else in this patch, although I'm not really familiar with farbtastic, so I can't be sure.
#3
(Changing status to patch-needs review. Sorry about forgetting that before.)