Hello,

Trying out the simple access module. Very nice work.

I received the following php error message:
implode(): Bad arguments. in simple_access.module on line 217.

I received this error message after creating groups (at ?q=admin/access/simple_access/add) -- I only got this error message if I didn't assign any roles to the group immediately as I created it.

If I created a group and assigned a role into it, I did not receive the error message.

From looking at the code, it appears that the error occurs when the list of groups is generated. If there is no value for roles, it throws an exception. I am not a programmer, but it looks like if the $r value in line 217 is null, the error message is generated.

This bug doesn't appear to affect any functionality, and it is pretty minor as it only seems to appear when the site admin is configuring groups incorrectly :) -- ie, not assigning any roles to a group.

I am running Apache 2.0, PHP 4.3.1, MySQL 4.1.8 in Windows XP.

Cheers,

bonobo

Comments

jjeff’s picture

Status: Active » Fixed

Bonobo,

Thank you for the feedback. It's really great to have others testing and using this module.

I've fixed this problem and committed to CVS.

Please let me know if you find any other problems.

- Jeff Robbins -
www.jjeff.com

Anonymous’s picture

Anonymous’s picture

jjeff’s picture

Version: » master
Status: Fixed » Closed (fixed)

  • Commit 103916d on 4.6.x-1.x, 4.7.x-1.x, 5.x-1.x, 5.x-2.x, 6.x-2.x, master, 8.x-3.x by jjeff:
    #26500 Fixed error that occurs if access group is created without any...
  • Commit ee03be8 on 4.6.x-1.x, 4.7.x-1.x, 5.x-1.x, 5.x-2.x, 6.x-2.x, master, 8.x-3.x by jjeff:
    Fix for #26794. Apparently the fix for #26500 broke some other things....