Simplify Xapian search configuration

Jeremy@kerneltr... - June 1, 2008 - 14:39
Project:xapian
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

The wording and terms used in the Xapian search configuration page are different from those used by Drupal's core search functionality, and as a result it's confusing when first using the module.

The Xapian search module is also confusing because it considers all indexing "reindexing", which is not always the case.

This patch attempts to cleanup the search configuration page, adding descriptions and making it much more similar to the Drupal core search configuration page. It also removes an extra cron-related option -- cron now simply checks if there are items queued, and if there are it indexes them.

The word "reindex" is being replaced with "index" to simplify the language.

The configuration options were reorderd, moving the performance settings higher on the settings page on the theory that it's a more important configuration option.

The reindex option now has a confirmation, explaining the impact of reindexing the site.

All wording is being reworked with the plan to support more than just nodes.

AttachmentSize
xapian.module.patch8.67 KB

#1

Jeremy@kerneltr... - June 1, 2008 - 14:50
Title:Simply Xapian search configuration, make more similar to Drupal core search configuration» Simplify Xapian search configuration

Shortening issue title...

#2

Jeremy@kerneltr... - June 1, 2008 - 14:56
Title:Simplify Xapian search configuration» Simply Xapian search configuration, make more similar to Drupal core search configuration

Patch updated so that immediate indexing is actually immediate, and queued indexing is actually queued. Also, replaced TRUE/FALSE switch with simpler if/else.

AttachmentSize
xapian.module.patch8.87 KB

#3

Jeremy@kerneltr... - June 1, 2008 - 15:41
Title:Simply Xapian search configuration, make more similar to Drupal core search configuration» Simplify Xapian search configuration

I hadn't noticed my first read through that the # of items waiting to be indexed disappears depending on the configuration -- I removed this logic so it is always displayed. (Even if indexing immediately, when you re-index the site it is queued up for cron).

I also reworded the re-index confirmation page to make it more clear. (It's more complex than standard Drupal search due to the ability to index immediately.)

AttachmentSize
xapian.module.patch8.96 KB

#4

singularo - June 2, 2008 - 01:42
Status:patch (code needs review)» fixed

#5

Anonymous (not verified) - June 16, 2008 - 01:51
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.