Hi,

I'm kind of new to all of this and I seemed to be stumped by the included patch in both the 2.5 and the dev versions of 5.x.

I'm using 5.7 and I would like to use this module, but I can't get the included patch to work.

I see this in the instructions:
0. Apply node.module.patch to give Drupal 5 a 'presave' op.

Now I have never patched before, but I did download and install patch. It seems to be working alright, except that I get this error:
patching file node.module
Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Press any key to continue . . .

Then it quits...

Now... I have never patched before and I don't know what this patch is for, I just assume I am supposed to use it since it is included. If you guys wouldn't mind, I have the following questions:
#1 - How can I apply this patch? Either I am doing something wrong or something is screwed up, I assume it is me.
#2 - How does one apply a patch to a core module on an already running site? It isn't production or anything, so I can start over if need be, but the node module can't be turned off. Do I just replace the patched file and it runs alright?

Thanks. I am sorry for being a newbie, I just believe that I should ask rather than screwing it up. I am trying to learn all of this and I have been trying to go through the modules alphabetically, selecting only the ones I need to test. It is the way my brain works, so I am stuck in the As, since I want Actions as part of my install. I would love to continue on testing.

Thanks.

Comments

vm’s picture

vm commented

It's a really simple patch, open the patch file in a txt editor, + means add the line of code. In the mean time if you want to push forward you can do it manually.

it's possible no one patched against Drupal 5.7 as doesn't know the patch is failing.

Anonymous’s picture

Anonymous (not verified) commented

Thanks for responding...

2 things confuse me though. The first is that there are things that don't have + signs, do I add those or what? Like this:

+  // Let modules modify the node before it is saved to the database.
+  node_invoke ($node, 'presave');
+  node_invoke_nodeapi($node, 'presave');
   global $user;
 
   $node->is_new = FALSE;

What about the global and $node parts? Are they included with the the last of the + signs?

Question 2 is probably more important. Should I even attempt this? I mean I don't know if it will work right and Actions seems rather important. Not having it patch right may be a concern. It is probably me, I mean I probably did something wrong. I just would feel more comfortable if I knew it would patch correctly.

vm’s picture

vm commented

you can write a new patch or wait for someone else to do so. a hunk failed could be as simple as a spacing problem.

the lines that don't have plus signs are already in the node.module this insures you are placing the code in the correct place that has + signs

Anonymous’s picture

Anonymous (not verified) commented

Thanks for the help. This was very confusing, since I had never patched before and I couldn't find information on what was happening.

I'll sit back and await a patch. I'm too new here to even think about trying something. I'm sure I would find a way to break my install.

Thanks again.

jvandyk’s picture

jvandyk commented
Status: Active » Closed (works as designed)

See http://drupal.org/node/310274#comment-1017758