Posted by floretan on June 1, 2008 at 11:17pm
5 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | block.module |
| Category: | task |
| Priority: | normal |
| Assigned: | floretan |
| Status: | needs work |
Issue Summary
I was working on a website in German, and noticed that the translator had translated the <none> placeholder (used to indicate that a block should not have a title) to <keine> (German for "none"), which of course doesn't work.
I'll file an issue against the German localization, but to keep translators from having to making these kinds of mistakes (they're not supposed to be developers) we should put non-localizable parts of strings passed to t() into placeholders:
t('Use <em><none></em> to display no title, or leave blank to use the default block title.')should be
t('Use !none to display no title, or leave blank to use the default block title.', array('!none' => '<em><none></em>'))This is just one example that I ran into, if there are more cases like this they should be added to this patch.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| block.admin_.inc_.patch | 1.05 KB | Ignored: Check issue status. | None | None |
Comments
#1
After discussing this issue with my friend who is a translator and who pointed out that the token
<none>didn't make sense on a localized website, I decided to completely remove the token from the user interface. The idea was based on panels2's block title override interface and looks like this:Here's a preliminary functional patch.
#2
Moving all usability issues to Drupal - component usability.
#3
See also #202837: Make it easier to customize a block title
#4
Re-rolled patch (also removed some unrelated chunk from a different issue).
I also took a look at #202837: Make it easier to customize a block title and there seems to be a few issues with that patch that aren't present with this one, so I decided to go ahead with it.
#5
I definitely like the idea behind this usability improvement, but I think it still needs work.
Upon applying the patch, the block configure page did change as expected (see Picture 6). However upon checking the box, no field appeared. I had to save the form, and then click configure again before I was presented withe the Overwrite Block Title field (see Picture 7).
#6