Problem/Motivation

PHP7 changed their Uniform Variable Syntax (according to this section of a lovely PHP7 reference document).

A search with following regex -\>\$[a-z0-9]*?\[ revealed a single location that is affected.

Proposed resolution

Use the new syntax with brackets to be php7 compatible.

Remaining tasks

Reviews needed.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
migrate-php7-uniform-variable-syntax.patch886 bytesdas-peter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

das-peter created an issue. See original summary.

SylvainM’s picture

SylvainM CreditAttribution: SylvainM at Axess Open Web Services commented
Status: Needs review » Reviewed & tested by the community

Patch works fine, thx

nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint commented
Parent issue: » #2554511: Plan for CTools 7.x-1.10 release
nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint commented
Parent issue: #2554511: Plan for CTools 7.x-1.10 release »
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi as a volunteer commented
Issue tags: +PHP 7.0 (duplicate)
twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Issue tags: -php7

Confirmed that this is the only occurrence.

  • pifagor committed 6daf645 on 7.x-2.x 
    Issue #2654222 by das-peter: PHP7 Uniform Variable Syntax. Issue #...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed

Done

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Fixed » Closed (fixed)