There's currently at least two issues against common.inc with tests attached but nothing to patch against, here's a stub for common.test

(issues for reference: http://drupal.org/node/265548 & http://drupal.org/node/151902)

CommentFileSizeAuthor
#3 commontest.patch1.8 KBcatch
commontest.patch298 bytescatch

Comments

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Reviewed & tested by the community

This looks good.

I'm honored to be the one to mark as RTBC the most trivial patch ever :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

I'm not sure it is useful to create stubs. Let's add the file when we have some actual tests to add, or let's make sure to add the referenced tests to the stub. :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Postponed
StatusFileSize
new commontest.patch1.8 KB

There's an IMO nearly ready test by MadHarold over at http://drupal.org/node/265548 - I've patchified it and it'll also add the common.test file in CVS. Marking this postponed in favour of that.

mrharolda’s picture

mrharolda commented

Not having a common.test to diff to is getting quite annoying... Let's hope one gets created/committed soon so my next patches still will apply properly...

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Fixed

We do now :)

http://drupal.org/node/151902

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.