Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As discussed with borisson_, we want all getters / setters to be explicit, so they can be overridden if necessary. The first part was done in https://www.drupal.org/node/2645128 This issue is for the actual setOption and getOption functions.
Comment | File | Size | Author |
---|---|---|---|
#23 | remove_set_getoption-2656226-23.patch | 17.4 KB | borisson_ |
#23 | interdiff.txt | 1.19 KB | borisson_ |
Comments
Comment #2
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedLets see what testbot says.
Comment #3
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedComment #4
borisson_After a quick look at the patch, I found this:
There's 2 $processor_settings here.
I'll take a look in more detail later.
Comment #5
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedOops.
Comment #10
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedSchema update missing.
Comment #13
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedAll of the above + url_processor_handler schema and widget_configs property change from string to array by default.
Comment #16
borisson_There are no settings intended for this, this will probably always be an empty array but not having a schema available means the facet config is not correct. This is important because the tests use strict config validation.
Looks great.
From the docs: https://www.drupal.org/coding-standards/docs
This should be
Sets the query operator.
This is a rule that I tend to forget myself as well ;)
Otherwise this patch is looking great, hopefully the testbot agrees.
Comment #17
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedTestbot does not agree. But at least he is a lot more verbose about it. Now I don't know why "show_numbers" is there...
Comment #18
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedAdditionally fixed:
- Minor issue in LinksWidget assuming $configuration['show_numbers'] to be set.
- camelCase vs snake_case in facet_source entity and schema
Comment #19
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedComment #22
borisson_fixes test.
Comment #23
borisson_Fixed my own remarks from #16.
Comment #24
borisson_Tests are green, happy with the code. Thanks for the patches!