Valid, semantinc HTML, more css classes and theme_ filtering
| Project: | Bible |
| Version: | 5.x-2.0-rc7 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Hello,
Thank you for this great module. It's really really helpful. I am having some issues with theming. Correct me if I am wrong, but at the moment only blocks are filtered through theme_ function? It looks like the rest of generated HTML is hardcoded in a way, that doesn't leave much space for skining it with CSS. For example bibile_all function returns just a table with no any classes, BLS filter produces HTML with styles embeded in tags (again, no classes, so no space for skinning with separate .css file). I think this part could use some work to make it more "Drupal way".
To recap, I think this great module needs to:
1) theme_ filter all HTML output.
2) produce valid semantic HTML without embeded styles (classes and external .css file instead)
I hope I am not mising anything.
Thanks, B.
PS: I am ready to help on this.
#1
Dear Friend:
Yeah.... I do need this help. Please let me know how to finish this.
MikeLee
#2
Hello again,
I will try to produce some code during next few days and post a patch here for review. Is this the preffered way for you?
Thanks, B.
#3
Dear Friend:
Yes. That will be great for me. Much thanks for the great help.
MikeLee
#4
Hello,
Attached you can find an archive with .patch file for bible.module and acompanying .css file. Please review it and eventually apply to the next release.
This patch changes bible_all function so it now filters all output through set of new theme_ functions. HTML code generated by these functions is fairly semantic, valid and skinable with css. CSS is also attached.
I am working to make the rest of the module's output themeable...
Thanks,
B.
#5
Hello again
Attached you can find zip file with updated patch do bible.module (generated against 5.x-2.0-rc7), a some addional .css and .js files that should be included in the module directory.
This update fixes some bugs I've found in my last patch and also theme_ filters code generating BLS filter output. All style settings for BLS filter has been moved to css, also BLS style configuration form has been removed as obsolete. With my patch you can style your BLS filter appearance using CSS. You can also override theme_ function that generates BLS output and make it behave in completelly different way.
Please comment.
Regards,
B.
#6
Updated bible_bls.js file. This should replace the same file from bible_patch.zip posted in my previous comment. This update is neccesary to allow BLS filter tooltip to work properly without the need of having jquery_update.module installed.
Regards,
B.
#7
Dear Friend:
According the files your attached, I've make some changes. But I need more time to get into my code....(Some feature is gone, like mousemove on multi-read...), so I put my lastest modify file for you to merge.
Thanks again for your great help. I've got many theme knowledge owning to these files....:)
MikeLee