userpoints_top_contributors.module doesn't use hook_userpoints() to add more settings in the userpoints.module settings form.

CommentFileSizeAuthor
#4 userpoints_top_contributors_0001.patch11.34 KBavpaderno

Comments

kbahey’s picture

kbahey commented
Project: User Points Contributed modules » User Points Top Contributors
Version: 5.x-3.x-dev » 5.x-1.x-dev
Component: Code: userpoints_top_contributors » Code

This is a separate project, no longer under the contrib collection.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

The patch resolves erroneous code like

variable_get(userpoints_top_contributors_period, 86400)

which should be written

variable_get('userpoints_top_contributors_period', 86400)
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: task » bug
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: userpoints_top_contributors.module needs cleanup » Code needs cleanup
Version: 5.x-1.x-dev » 5.x-1.0
StatusFileSize
new userpoints_top_contributors_0001.patch11.34 KB

I have some problems on attaching patches.
This patch is for all the project, version 5.x-1.0 dated April 15th.

kmillecam’s picture

kmillecam commented
Status: Needs review » Closed (fixed)

Thanks Kiam,

Committed to Dev.