Code needs cleanup
kiamlaluno - June 2, 2008 - 16:50
| Project: | User Points Top Contributors |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
userpoints_top_contributors.module doesn't use hook_userpoints() to add more settings in the userpoints.module settings form.
#1
This is a separate project, no longer under the contrib collection.
#2
The patch resolves erroneous code like
<?phpvariable_get(userpoints_top_contributors_period, 86400)
?>
which should be written
<?phpvariable_get('userpoints_top_contributors_period', 86400)
?>
#3
#4
I have some problems on attaching patches.
This patch is for all the project, version 5.x-1.0 dated April 15th.
#5
Thanks Kiam,
Committed to Dev.