Code needs cleanup

Posted by kiamlaluno on June 2, 2008 at 4:50pm

Issue Summary

userpoints_top_contributors.module doesn't use hook_userpoints() to add more settings in the userpoints.module settings form.

Posted by kbahey on June 2, 2008 at 4:53pm

Project:	User Points Contributed modules	» User Points Top Contributors
Version:	5.x-3.x-dev	» 5.x-1.x-dev
Component:	Code: userpoints_top_contributors	» Code

This is a separate project, no longer under the contrib collection.

Posted by kiamlaluno on June 4, 2008 at 11:18pm

Status:

active

» needs review

The patch resolves erroneous code like

<?php
variable_get(userpoints_top_contributors_period, 86400)
?>

which should be written

<?php
variable_get('userpoints_top_contributors_period', 86400)
?>

Posted by kiamlaluno on June 4, 2008 at 11:37pm

Category:

task

» bug report

Posted by kiamlaluno on June 13, 2008 at 12:48pm

Title:	userpoints_top_contributors.module needs cleanup	» Code needs cleanup
Version:	5.x-1.x-dev	» 5.x-1.0

I have some problems on attaching patches.
This patch is for all the project, version 5.x-1.0 dated April 15th.

Attachment	Size
userpoints_top_contributors_0001.patch	11.34 KB

Posted by kmillecam on June 30, 2008 at 12:37am

Status:

needs review

» closed (fixed)

Thanks Kiam,

Committed to Dev.

Project:	User Points Top Contributors
Version:	5.x-1.0
Component:	Code
Category:	bug report
Priority:	normal
Assigned:	Unassigned
Status:	closed (fixed)