In 6.x-1.0, the sidebar-wrapper is not expanding to the bottom of the content div,
so with only a couple of things in the menu, the sidebar_top and sidebar_bottom jpgs
aren't displaying properly.

Sorry... I don't know enough about css to suggest a fix.

cheers.

Comments

-Anti-’s picture

-Anti- commented

> Sorry... I don't know enough about css to suggest a fix

I gave sidebar-wrapper a fixed minimum height, like:

#sidebar-wrapper {
min-height: 300px;
}

and the graphical problem (sidebar_top.jpg being 'cut off' when the menu is very short) is resolved.

-Anti-’s picture

-Anti- commented

double post - drupal is playing up at the mo'

jwolf’s picture

jwolf commented
Status: Active » Closed (works as designed)

The sidebar-wrapper isn't supposed to expanded to the bottom of the content; it expands the length of the sidebar. So, yes, if the sidebar is short so is the graphic.

-Anti-’s picture

-Anti- commented

> The sidebar-wrapper isn't supposed to expanded to the bottom of the content; it
> expands the length of the sidebar.

Yep. It was a surprise at first, but after some reflection, I actually prefer it that way too.
It doesn't 'crowd' or 'hem in' the content so much; a nice, open feel.

> So, yes, if the sidebar is short so is the graphic.

It probably isn't a problem 99% of the time, because most website menus will be longer than 300px.
But it looked a bit ugly on a new install though, because only the collapsed 'nav' menu displays.

By the way, I was doing some edits to your theme tonight.
It is by far the easiest one that I've tried to make small changes to so far.

Awesome work; thanks for releasing this as a free theme.
It's perfect for my school website.

Cheers.

jwolf’s picture

jwolf commented

Be sure to send a link of your project when it's complete; I would enjoy seeing what you have done.

jwolf’s picture

jwolf commented

BTW... if the longer sidebar_top.jpg bothers you, you can download an older version of the theme and the sidebar_top.jpg is shorter - just replace the longer one with the shorter sidebar_top.jpg

-Anti-’s picture

-Anti- commented

> BTW... if the longer sidebar_top.jpg bothers you

Nope... all is fine with the min-height fix (except for IE6, but that serves them right!).

> Be sure to send a link of your project when it's complete

Here's what I did so far tonight on a test site: pulpo dot co dot uk
Not much, I know, but I don't know css, so it's very slow.
Plus I don't want to change it too much anyway, because it's a great theme.

· widened the container a little (994px, which I think is the maximum for 1024 resolution).
· put some left-padding to keep content away from the edge of the browser in <=1024 res.
· Also used html { overflow: scroll; } (which always shows a scrollbar to stop 'horizontal pageshift').
· put left and right dashed borders on to give an indication where the edges are.
· styled the nav menu to make it more 'button-like' (that took me most of the evening).
· changed the header to the school colours.
· styled the footer.
· added the secondary menu under the header (still needs to be styled)

Tomorrow I'm going to try to put a region in the header.