user2userpoints.module uses an array containing the key 'event' to call userpoints_userpointsapi(), which is documented to accept an array with the key'operation'.

Comments

kbahey’s picture

kbahey commented
Status: Active » Closed (duplicate)

http://drupal.org/node/265714

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Closed (duplicate) » Active

It's not exactly a duplicate, if it refers to a different module.

kbahey’s picture

kbahey commented
Status: Active » Closed (duplicate)

No it is duplicate.

Only after the API is changed would this need to be done.

So far, the modules are using the right parameter name.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Closed (duplicate) » Active

The parameter $params['event'] is wrong because userpoints_userpoints() uses $params['operation'].
Using $params['operation'] will cause any transictions passed to userpoints_userpoints() to be recorded in the DB table with a NULL value.

I see two different bugs here: a "bug" in the documentation put in the README.txt file, and a bug in any module which passes $params['event'] to userpoints_userpoints().
Both must be resolved, but both exist.

kbahey’s picture

kbahey commented
Status: Active » Closed (duplicate)

See the duplicate issue.

We will fix things in the API first. Review the patch there.

After this is fixed, we can do one issue for all of userpoints_contrib modules in one go (single patch), since it is the same change for all the modules.

Don't change statuses on the duplicate issues anymore.