userpoints_ecommerce.module uses an array containing the key 'event' to call userpoints_userpointsapi(), which is documented to accept an array with the key'operation'.

Comments

kbahey’s picture

Status: Active » Closed (duplicate)
avpaderno’s picture

Status: Closed (duplicate) » Needs review

It's not a duplicate, as it refers to different modules.
All the modules for which I opened the issue pass an array containing the key 'event' to userpoints_userpointsapi(), which is documented to accept the key 'operation' (I meant the inline documentation placed in the comment right before the function definition states so).

Before I was asked to spit an issue in different ones, because the modules come from different contributors; now I am doing the same for this issue.

The problem is not with userpoints_userpointsapi(), but with the modules which use it.

avpaderno’s picture

Status: Needs review » Active

Oops, I set the status to the wrong value. I am sorry.

kbahey’s picture

Status: Active » Closed (duplicate)

Read the comments in the duplicate issue first.

avpaderno’s picture

I have already done that, but the issues are different.

Whatever you put in the documentation, "an error, flaw, mistake, 'undocumented feature', failure, or fault in a computer program that prevents it from behaving as intended (e.g., producing an incorrect result)" is still a bug.
If the documentation is wrong, then it needs to be correct, but that doesn't make a bug a "new feature".