Sharpening for Imagecache

Moonshine - June 3, 2008 - 19:23
Project:ImageCache
Version:HEAD
Component:Code
Category:feature request
Priority:normal
Assigned:Moonshine
Status:closed
Description

This patch adds a "Sharpen" action to Imagecache. It *requires* an updated ImageAPI via this patch:

#266265: Sharpening for ImageAPI/Imagecache

AttachmentSize
imagecache-sharpening-v1.patch3.55 KB

#1

Moonshine - June 4, 2008 - 19:15

New patch for use with new ImageAPI patch and GD unsharp masking.

AttachmentSize
imagecache-sharpening-v2.patch3.72 KB

#2

Fayna - June 24, 2008 - 17:51

I patched ImageAPI and ImageCache but I don't see a "Sharpen" action. >.<

#3

Moonshine - June 25, 2008 - 05:31

That's odd. Assuming you've patched HEAD and are using D6, it should show up as the last action available in the "New Actions" fieldset. The label is:

"Add Sharpen - Sharpen an image using unsharp masking."

If you still don't see anything, maybe you can take a peek in "imagecache.module" to see if the patch was applied. A search for "imagecache_sharpen", it should find the action definition if the patch was applied properly.

I'll revert here and apply the patches myself also.

#4

Moonshine - June 25, 2008 - 05:54

Just applied the patches to current Imagecache and ImageAPI HEAD code, and it seems to work fine. However, you will need to clear Drupal's cache via the the Performance admin page or the Devel module for the action to appear.

#5

Fayna - June 25, 2008 - 13:25

Okay I see it now! Cool. :-) It works great!

#6

dopry - July 9, 2008 - 03:00
Status:patch (code needs review)» fixed

oh hey, committed. to DRUPAL-5 and HEAD.

#7

Anonymous (not verified) - July 23, 2008 - 10:56
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.