I have a file field in the middle of my form, and the following field flows around it (in firefox3b5 and firefox2.0.0.14). It displayed OK in IE7

A quick fix was to change the icon to display: "block" instead of "inline". It worked in all three with this change.

It could be any combination of my browser, theme, and particular selection of fields, but it seems this would cover all cases. Was there a reason "inline" was specified when it's already "float: left"?

CommentFileSizeAuthor
#6 filefield-clear.patch551 bytesjoachim
filefield-css.patch284 bytesmichael_kirk
block_vs_inline_display_filefield.png16.04 KBmichael_kirk

Comments

jpetso’s picture

jpetso commented

No particular reason for inline from my side, I think that line was already there when I came here. I don't really see obstacles to change this if it works - just need to test this out for myself, then I can apply this patch.

It doesn't by any chance work with block instead of inline *and* float removed? Because float is what really causes the problems I believe, I just didn't have enough CSS practice to make it work without float but still using a div wrapped around the icon img. If you know how to achieve that and keep the looks, make sure to tell me.

Anyways, thanks for reporting this issue. I wonder if the number of people who are majorly annoyed by that is very large...

michael_kirk’s picture

michael_kirk commented

If you removed the float left, the icon and the text would be on different lines. The float is needed to enable the text to flow around the icon (in this case, on the same "line" as it).

jpetso’s picture

jpetso commented

Ok, I thought maybe there's some way to get the icon div on the same line even without using float. If that's not possible, that's ok too, I'll probably commit your patch as is then. (Scheduled for tomorrow.)

dopry’s picture

dopry commented

You can put a clear-block class on the outer container and it should expand to contain the icon...

dopry’s picture

dopry commented
Status: Needs review » Closed (fixed)

I believe this was fixed with a clear... reopen if not..

joachim’s picture

joachim commented
Version: 5.x-2.3 » 5.x-2.4
StatusFileSize
new filefield-clear.patch551 bytes

Not fixed in 2.4.

Here's a patch.

joachim’s picture

joachim commented
Status: Closed (fixed) » Needs review
quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Thanks joachim. Applied to the 5.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

happyloman’s picture

happyloman commented

This is still a bug in 6.x