Closed (fixed)
Project:
Drupal core
Component:
theme system
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
13 Jul 2005 at 17:46 UTC
Updated:
5 Oct 2005 at 22:00 UTC
Jump to comment: Most recent file
The documentation to theme_node clearly says the the parameter $teaser is "Whether to display the teaser only, as on the main page." Naming this parameter $main in the themes is confusing. Main is used elsewhere to mean "whether to show full view or teaser view", but the meaning of $teaser seems to be subtly different.
An alternate to the patch I'm suggesting would be to eliminate $teaser altogether, system-wide. The variable $main makes it clear that it is transmitting state (whether or not on the node's main page), whereas the variable $teaser makes on think it is transmitting the actual teaser.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | phptemplate_engine_patch.txt | 1.54 KB | robertdouglass |
| #4 | main_teaser2.patch.txt | 3.16 KB | robertdouglass |
| main_teaser.patch.txt | 3.1 KB | robertdouglass |
Comments
Comment #1
Thox commentedI don't follow your logic why $teaser needs to be renamed, especially if $main is the alternative. If RSS wants to only show the teaser, does $main=true make sense?
Comment #2
Bèr Kessels commented+1 from me. It removes another variable. and it increases the logic. Instaed of using inversed logic, we now all use one single variable.
Comment #3
Thox commentedI must have been half asleep. It does make sense, and it is logical.
+1
Comment #4
robertdouglass commentedUpdated so that it still applies.
Comment #5
dries commentedCommitted to HEAD. Thanks. Please update the theme migration documentation. Thanks.
Comment #6
robertdouglass commentedThe change to phptemplate.engine didn't get made.
Comment #7
dries commentedCommitted to HEAD. Thanks.
Comment #8
(not verified) commentedComment #9
(not verified) commentedComment #10
(not verified) commentedComment #11
(not verified) commentedComment #12
(not verified) commented