Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
tests
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Jun 2008 at 07:13 UTC
Updated:
19 Jun 2008 at 18:24 UTC
The comment tests were still using a 'story' node type which doesn't ship with drupal Core anymore. Fixed in the patch.
The comment tests currently has 18 fails. This is because of this part:
$anonymous_comment3 = $this->postComment($this->node, $this->randomName(), $this->randomName(), TRUE, TRUE);
$this->assertText(t('E-mail field is required.'), t('E-mail required.')); // Name should have 'Anonymous' for value by default.
$this->assertFalse($this->commentExists($anonymous_comment3), t('Anonymous comment with contact info (required) not found.'));
// Post comment with contact info (required).
$anonymous_comment3 = $this->postComment($this->node, $this->randomName(), $this->randomName(), FALSE, array('mail' => 'tester@simpletest.org'));
$this->assertTrue($this->commentExists($anonymous_comment3), t('Anonymous comment with contact info (required) found.'));
The first postComment threats the comment with preview = TRUE and the second one used preview = FALSE. But the setting for preview doesn't get flipped in the middle. It is fixed in this patch by using TRUE for the second time too.
| Comment | File | Size | Author |
|---|---|---|---|
| comment_tests_article.patch | 1.89 KB | R.Muilwijk |
Comments
Comment #1
catchAll looks great to me and fixes the errors. Core tests not passing is critical though ;)
Comment #2
catchComment #3
dries commentedCommitted to CVS HEAD. Thanks R.
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.