Many thanks for this Module, it is just what I have being looking for.

However, I am currently seeing 2 of each of the icons for each link in Firefox and it would appear there are two icons in IE 7 but they overlap so not as obvious. ( i have attached a screenshot from FF2).

My settings are:

Block Type: Image Links [1]
List Display: Inline
Text Display: Hide Text in the Links
Hide Current Page Style

Is there a better combination of settings to achieve the same effect? If the icons weren't shown in duplicate, this is exactly what I would like.

CommentFileSizeAuthor
page style.png4.05 KBcehwitham

Comments

cehwitham’s picture

cehwitham commented
Title: Doucle Icons » Doucle Icons Fixed?

I have removed the bits of code like:

Only local images are allowed.

From lines 420, 421, 422 and 423 of pagestyle.module which seems to have solved this problem and still gives the full functionality of the module.

Can anyone see a problem with remove these image tags?

cehwitham’s picture

cehwitham commented
Title: Doucle Icons Fixed? » Doucle Icons Fixed? No

I had only tested this in Firefox which it gives the correct result. In IE7 no icons are displayed.

mrfelton’s picture

mrfelton commented

As far as I could tell, no icons appear in IE 7 because it relies on on an empty tag with a background image applied via css - which IE will not render. I altered the module and added a   into the tag, which brought back the icons in IE7:

pagestyle.module - lines 356-358

  $output .= '<li><a title="'. $prefix['title'] .': '. $pagestyle_text['black_white'] .'" class="icon pagestyle_black_white" href="'. $tb_url .'?pagestyle=black_white" >&nbsp;<span class="'. $pagestyle_hidden .'">'. $pagestyle_text['black_white'] .'</span></a></li>'."\n";
  $output .= '<li><a title="'. $prefix['title'] .': '. $pagestyle_text['white_black'] .'" class="icon pagestyle_white_black" href="'. $tb_url .'?pagestyle=white_black" >&nbsp;<span class="'. $pagestyle_hidden .'">'. $pagestyle_text['white_black'] .'</span></a></li>'."\n";
  $output .= '<li><a title="'. $prefix['title'] .': '. $pagestyle_text['yellow_blue'] .'" class="icon pagestyle_yellow_blue" href="'. $tb_url .'?pagestyle=yellow_blue" >&nbsp;<span class="'. $pagestyle_hidden .'">'. $pagestyle_text['yellow_blue'] .'</span></a></li>'."\n";

Obviously this is a bad way to fix it, but it it did work. This is only a problem when the text links are disabled.

I think it might also be something to do with the way the text links get hidden, but I'm not exactly sure how:

.display_hidden {
  position: absolute;
  left: -1000px;	
  top: -1000px;
  width: 0px;
  height: 0px;
  overflow: hidden;
  display: none;
}
cehwitham’s picture

cehwitham commented

I'm out of the office for 6 weeks but I'll try this fix when I get back.

Thanks

CZ’s picture

CZ commented

Delete the class pagestyle_white_black, pagestyle_yellow_blue and pagestyle_standard in the function theme_pagestyle_html2() on line 420-423.

CZ’s picture

CZ commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.