Project:Drupal core
Version:7.x-dev
Component:trigger.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

actions_syncronize() didn't use db_placeholders() as it should've plus a few other small changes.

AttachmentSizeStatusTest resultOperations
actions.inc_.patch2.2 KBIgnored: Check issue status.NoneNone

Comments

#1

Also, I pegged #246522: Typo in function documentation in actions.inc into this patch as it's such a small change that I figured it'd get in easier if it was part of a more worthwhile patch.

#2

All SimpleTests still pass, though I'm not sure if any test this function.

#3

Nice job. Re-rolled patch for changes to actions.inc and works perfectly.

AttachmentSizeStatusTest resultOperations
266773.actions_syncronize.patch1.81 KBIgnored: Check issue status.NoneNone

#4

Status:needs review» reviewed & tested by the community

Patch still applies cleanly, passes all tests, and provides a small cleanup in code that reduces 11 lines of code to 3 without increasing complexity. Ready to be committed.

#5

I've asked John to take a look at this.

#6

Status:reviewed & tested by the community» needs review

#7

Status:needs review» reviewed & tested by the community

Tested and works as expected.

#8

Status:reviewed & tested by the community» fixed

Thanks, committed. :)

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here