It's a little strange to be starting an issue that I fully expect you to "won't fix" but I wanted you to be aware of this and also have it in the queue for people searching. Consider it a pre-emptive strike. ;)

Anyway, because you are defining phptemplate_forum_topic_navigation and phptemplate_forum_icon, anyone using advanced forum will get errors from the functions being redefined. The fix (for the user; I'm not expecting you to do it) is simply to remove those two functions from template.php.

You might want to consider adding a note to the project page about it, but that's up to you.

Michelle

Comments

psynaptic’s picture

psynaptic commented

Wouldn't it be fixed by defining the function in template.php as blueprint_*?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Well, it would keep it from crashing but those functions would override the ones in advforum, then. For the topic navigation, that's not a big deal since, IIRC, the theme is doing the same thing I am. It could be an issue with the icons, though. Not a huge deal, though, and better than it crashing.

Michelle

m3avrck’s picture

m3avrck commented

So which is interfering with the other? It seems the theme should be the source of this so it is the module encroaching on this territory right?

Is there a warning in advanced forum for this?

I think that might suffice but I'd be happy to add a note to this module as needed. Let me know what you recommend.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

It could go either way. Themes can use use the theme name, instead of phptemplate_. Modules don't have that ability. Using the theme name in this case, though, would fix the namespace conflict but potentially cause confusion because they would override those functions in advforum.

Yeah, I should add a note to advforum's docs. Up to you if you want to add a warning as well. I just filed this issue so it was there for people using this theme to find if they ran into problems. Thankfully this is only a problem in 5.x. :)

Michelle

m3avrck’s picture

m3avrck commented
Status: Active » Closed (won't fix)

Ok I'm going to mark as "won't fix" and add a note to the homepage and README for people that run both, thanks for the preemptive post!

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Sounds good. I've got some doc work coming up on advforum and I'll include a warning in there as well.

Thanks,

Michelle

designerbrent’s picture

designerbrent commented
Version: 5.x-1.0 » 6.x-1.3
Status: Closed (won't fix) » Fixed

This should be fixed with the most recent version, 1.3.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.