Banners not displaying

I'm having the same problem.

Drupal version: 4.6.5
PHP version: 4.3.10

It works with this patch though:

--- banner_db.orig.php 2006-01-05 12:13:11.000000000 +0100
+++ banner_db.new.php 2006-01-05 12:13:14.000000000 +0100
@@ -8,15 +8,15 @@
include_once "includes/common.inc";
list($ballot, $banners) = _banner_get_struct();

- $max = count($ballot[$pos]) - 1;
+ $max = count($ballot[0][$pos]) - 1;
if ($max > 0) {
$random = mt_rand(0, $max);
}
else {
$random = 0;
}
- $id = $ballot[$pos][$random];
- $banner = $banners[$id];
+ $id = $ballot[0][$pos][$random];
+ $banner = $banners[0][$id];

$banner->views++;

Or download my version from: http://qux.nl/banner_db.php.txt

Confirmed, this patch works for me, with the latest HEAD checkout (NOT the latest bundled 4.6.0 version, which doesn't seem to work at all).

You don't want to hardcode [0] because that's the tid.

You should pick out the $tid from the request. Here's a diff (also described in http://drupal.org/node/36805).

RCS file: /cvs/drupal/contributions/modules/banner/banner_db.php,v
retrieving revision 1.10
diff -u -r1.10 banner_db.php
--- banner_db.php       19 Apr 2005 12:57:42 -0000      1.10
+++ banner_db.php       25 Jan 2006 06:27:41 -0000
@@ -3,20 +3,22 @@
   header("content-type: application/x-javascript");

   $pos = (int)$_GET["pos"];
+  $tid = (int)$_GET["tid"];

   include_once "includes/bootstrap.inc";
   include_once "includes/common.inc";
   list($ballot, $banners) = _banner_get_struct();

-  $max = count($ballot[$pos]) - 1;
+  $max = count($ballot[$tid][$pos]) - 1;
   if ($max > 0) {
     $random = mt_rand(0, $max);
   }
   else {
     $random = 0;
   }
-  $id = $ballot[$pos][$random];
-  $banner = $banners[$id];
+  $id = $ballot[$tid][$pos][$random];
+  $banner = $banners[$tid][$id];

   $banner->views++;

yes, when i make a patch banner shows up! but they are not rotating! only first banner on list is showing up!! anybody else can confirm that they are rotating?

It ok, works now! messed up something :(

Good Work It!
Funciono... jaja

Slightly modified version committed. Thanks!