PostgreSQL errors

The Archive module does not work properly with PostgreSQL for the following reasons.

Quoting: In PostgreSQL, double quotes signify a column name. Several queries in the Archive module use double quotes where single quotes should be used.

GROUP and ORDER: The archive pages use the following query, which fails in PostgreSQL:

$result = db_query(db_rewrite_sql("SELECT t.type, t.name, COUNT(n.nid) AS node_count FROM {node} n INNER JOIN {node_type} t ON t.type = n.type WHERE n.status = 1 AND t.type IN ('". join($types, "', '") ."') GROUP BY n.type ORDER BY n.created"))

I'm assuming that MySQL ORDERs the results before it GROUPs them. I can't comment as to whether this is correct from a standards standpoint, but this query fails in PostgreSQL.

You can get around this with PostgreSQL by using a sub-select. Here's code that works:

$result = db_query(db_rewrite_sql("SELECT r.type, r.name, COUNT(r.nid) AS node_count FROM (SELECT t.type, t.name, n.nid FROM {node} n INNER JOIN {node_type} t USING (type) WHERE n.status = 1 AND t.type IN ('". join($types, "', '") ."') ORDER BY n.created) AS r GROUP BY r.type, r.name"));

Patch: I'm attaching a patch that fixes both of these issues. Since I cannot test whether the sub-select will work in MySQL, I've created a simple test to see if $db_type = "pgsql" and if so, use the sub-select query. If that query works in MySQL as well, you can probably just use that one and get rid of the other version.