Posted by boombatower on June 5, 2008 at 11:35pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed (fixed) |
Issue Summary
This patch checks permissions passed to drupalCreateUser to ensure that invalid permissions aren't accidentally used.
This is very helpful in spotting out-dated tests and typos.
Requested by Dries http://drupal.org/node/266539#comment-871680, but mentioned several times before.
Comments
#1
Hmm...patch was there when I previewed.
#2
Oh, *awesome*!
One suggestion I have is to add static caching to that $available array. It's probably expensive to re-generate that each time drupalCreateUser is called.
see http://www.lullabot.com/articles/a_beginners_guide_to_caching_data for more info.
#3
Oh, also, you're missing a patch to simpletest.test to make sure this function is working properly. ;)
#4
Hum. Just a though here, why not implement that check in
user_access()in order to enforce it everywhere in Drupal? I remember that this loosely typed permission bit me several times.#5
Updated to include test and caching.
#6
Any thoughts on #4. I would be for it.
#7
I would leave #4 for another issue. I'm not sure I'd want to check the permissions for every page view. I'd try to work it into devel.module or so.
#8
Ok, so any reviews? :)
#9
It's a good idea and all the tests pass, RTBC.
#10
Commited to CVS HEAD. Thanks again, boombatower.
#11
Automatically closed -- issue fixed for two weeks with no activity.