Files ending in .inc are not allowed in the profile directory. This should be fixed to allow .profile, .txt and .inc as well.

CommentFileSizeAuthor
#6 cvslog-xcvs-267313-006.patch1.14 KBaclight
#5 cvslog-xcvs-267313-005.patch1.32 KBmikey_p
#3 cvslog-xcvs-267313-003.patch1.12 KBmikey_p

Comments

mikey_p’s picture

mikey_p commented

Updating this, please see http://cvs.drupal.org/viewvc.py/drupal/contributions/sandbox/mikeyp/packgr/ for an example.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

As noted in IRC, the way to change this would be to patch the $xcvs['commit_deny_files'] variable in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/cvslog/xcvs.... The commented out version is the one used on drupal.org.

If this request is accompanied by a patch, it'd be much easier for dww or someone to implement.

mikey_p’s picture

mikey_p commented
Status: Active » Needs review
StatusFileSize
new cvslog-xcvs-267313-003.patch1.12 KB

Here ye go.

In all honestly I don't know how one is supposed to know that a infrastructure specific settings just happens to be stored as a comment in a module committed to CVS, but thanks to angie, here's a patch.

aclight’s picture

aclight commented
Status: Needs review » Needs work

The code comment also needs to be changed to reflect the change in file extensions allowed.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review
StatusFileSize
new cvslog-xcvs-267313-005.patch1.32 KB

Done

aclight’s picture

aclight commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new cvslog-xcvs-267313-006.patch1.14 KB

Here's the same patch without the change in the CVS metadata.

Code looks good. Untested however.

I'd like this to be committed and used on d.o because #231640: Auto-generate some release nodes introduces a .inc for the drupalorg_testing profile.

mikey_p’s picture

mikey_p commented

Also, thought I'd throw out another example of the COD distribution which has taken to placing data/code in .txt files to workaround this limitation (since they have ALOT of data).

http://cvs.drupal.org/viewvc.py/drupal/contributions/profiles/cod/cck/

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Reviewed & tested by the community » Fixed

Sorry, I have no idea how this fell off my radar for so long. :( Committed something like #6 to the private repo and deployed it on cvs.d.o.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Component: CVS » Other