Allow .inc files in contributions/profiles

mikey_p - June 5, 2008 - 23:52
Project:Drupal.org infrastructure
Component:CVS
Category:feature request
Priority:normal
Assigned:dww
Status:closed
Description

Files ending in .inc are not allowed in the profile directory. This should be fixed to allow .profile, .txt and .inc as well.

#1

mikey_p - June 11, 2008 - 21:03

#2

webchick - June 16, 2008 - 01:08

As noted in IRC, the way to change this would be to patch the $xcvs['commit_deny_files'] variable in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/cvslog/xcvs.... The commented out version is the one used on drupal.org.

If this request is accompanied by a patch, it'd be much easier for dww or someone to implement.

#3

mikey_p - June 25, 2008 - 20:32
Status:active» needs review

Here ye go.

In all honestly I don't know how one is supposed to know that a infrastructure specific settings just happens to be stored as a comment in a module committed to CVS, but thanks to angie, here's a patch.

AttachmentSize
cvslog-xcvs-267313-003.patch 1.12 KB

#4

aclight - June 25, 2008 - 20:36
Status:needs review» needs work

The code comment also needs to be changed to reflect the change in file extensions allowed.

#5

mikey_p - June 25, 2008 - 20:39
Status:needs work» needs review

Done

AttachmentSize
cvslog-xcvs-267313-005.patch 1.32 KB

#6

aclight - June 25, 2008 - 20:50
Status:needs review» reviewed & tested by the community

Here's the same patch without the change in the CVS metadata.

Code looks good. Untested however.

I'd like this to be committed and used on d.o because #231640: Auto-generate some release nodes introduces a .inc for the drupalorg_testing profile.

AttachmentSize
cvslog-xcvs-267313-006.patch 1.14 KB

#7

mikey_p - June 25, 2008 - 20:54

Also, thought I'd throw out another example of the COD distribution which has taken to placing data/code in .txt files to workaround this limitation (since they have ALOT of data).

http://cvs.drupal.org/viewvc.py/drupal/contributions/profiles/cod/cck/

#8

dww - October 12, 2008 - 01:54
Assigned to:Anonymous» dww
Status:reviewed & tested by the community» fixed

Sorry, I have no idea how this fell off my radar for so long. :( Committed something like #6 to the private repo and deployed it on cvs.d.o.

--project followup subject--

Anonymous (not verified) - October 26, 2008 - 02:05

Automatically closed -- issue fixed for two weeks with no activity.

#9

Anonymous (not verified) - October 26, 2008 - 02:13
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.