Allow .inc files in contributions/profiles
mikey_p - June 5, 2008 - 23:52
| Project: | Drupal.org infrastructure |
| Component: | CVS |
| Category: | feature request |
| Priority: | normal |
| Assigned: | dww |
| Status: | closed |
Description
Files ending in .inc are not allowed in the profile directory. This should be fixed to allow .profile, .txt and .inc as well.
#1
Updating this, please see http://cvs.drupal.org/viewvc.py/drupal/contributions/sandbox/mikeyp/packgr/ for an example.
#2
As noted in IRC, the way to change this would be to patch the $xcvs['commit_deny_files'] variable in http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/cvslog/xcvs.... The commented out version is the one used on drupal.org.
If this request is accompanied by a patch, it'd be much easier for dww or someone to implement.
#3
Here ye go.
In all honestly I don't know how one is supposed to know that a infrastructure specific settings just happens to be stored as a comment in a module committed to CVS, but thanks to angie, here's a patch.
#4
The code comment also needs to be changed to reflect the change in file extensions allowed.
#5
Done
#6
Here's the same patch without the change in the CVS metadata.
Code looks good. Untested however.
I'd like this to be committed and used on d.o because #231640: Auto-generate some release nodes introduces a .inc for the drupalorg_testing profile.
#7
Also, thought I'd throw out another example of the COD distribution which has taken to placing data/code in .txt files to workaround this limitation (since they have ALOT of data).
http://cvs.drupal.org/viewvc.py/drupal/contributions/profiles/cod/cck/
#8
Sorry, I have no idea how this fell off my radar for so long. :( Committed something like #6 to the private repo and deployed it on cvs.d.o.
--project followup subject--
Automatically closed -- issue fixed for two weeks with no activity.
#9
Automatically closed -- issue fixed for two weeks with no activity.