Following up on #204497: Make the background fill color configurable where image styles result in blank space and #199957: Add new feature 'Allow Upcropping' to image crop effects:

imageapi_image_crop() should ensure that the recalculated image dimensions are actually inside the original image dimensions.

CommentFileSizeAuthor
imageapi-DRUPAL-5.crop_.patch865 bytessun

Comments

dopry’s picture

Status: Needs review » Fixed

committed to Drupal-5... We'll have a real crop instead of a canvas resize I guess. It would be nice to get the canvas resize with background color control though.

sun’s picture

Great, thanks!

Yeah, that sounds like a nice-to-have feature -- but rather for ImageAPI 3.x, along with image canvas resizing and two-image blending features (since a custom background-color wouldn't be that helpful at all). All in all, probably better suited in another contrib module that relies on ImageAPI, because I'd bet that most users won't need such features.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.