This module would become even more useful if it could remember selected by a user tab and with next refresh of the page could load previously selected by the user tab as opposed to always loading the first tab, the default behavior for now.

Comments

yhager’s picture

yhager commented

are you thinking user-tab cache, or session-tab cache?

yngens’s picture

yngens commented

I am not sure of the difference between the two. You will see what I mean if you go to http://www.gazeta.kg and try to press any of the tabs on the right, then go to any other page and return to the first page - it will load the tab that you chose last time, not the default first one.

yhager’s picture

yhager commented
Title: Make use of cache memory for selected tabs » Show user's previously selected tab instead of default tab
Assigned: Unassigned » yhager

In the example site you sent, the selected tab is saved in a session cookie.

It's a very good idea, I'll work on that.

yngens’s picture

yngens commented

thanks! looking forward to see this feature in your module.

d0t101101’s picture

d0t101101 commented

As am I :)

Also, it would be helpful to have a way to set the default tab programmatically, inside the callback. A use case would be when magic_tabs are used on profile pages. One might want to view the 'Latest' tab for their own profile by default, and view the 'About' tab on everyone elses profile page.

For the above, you wouldn't want to change the order of the tabs, but simply set the default...

Just a thought,
.

yhager’s picture

yhager commented

Also, it would be helpful to have a way to set the default tab programmatically, inside the callback. A use case would be when magic_tabs are used on profile pages. One might want to view the 'Latest' tab for their own profile by default, and view the 'About' tab on everyone elses profile page.

This can be achieved with the existing code, just use

  print magic_tabs_get('yourcallback', 'last');

the second parameter can be 'first' (default), 'last', or a numeric value.

d0t101101’s picture

d0t101101 commented

THANKS!!!

And sorry, I should have RTFM before posting the last comment ;)
.

yngens’s picture

yngens commented

Hi Yuval,

Can you please give any approximate terms when the initial request could be realized. I would like to shift all of my websites to magictabs, but waiting for only this feature. Otherwise the modules is just awesome.

yhager’s picture

yhager commented

@yngens, I was waiting for SA-2008-032 to be published. Now that it's done I hope to get this going within a week or so.

Please remember I'm doing this is done on free time on a voluntary basis.

yngens’s picture

yngens commented

sure i do see that and actually was asking my question without any intention to make you hurry, just to plans my own priorities according to your plans. thank you very much for this module!

yhager’s picture

yhager commented
Status: Active » Fixed

this fix is now in the CVS, and will soon be in the development snapshot (make sure you use snapshot from today or later, or use the CVS directly).

yngens’s picture

yngens commented

thanks man, you are the great!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.