Views2 integration

zmove - June 6, 2008 - 09:18
Project:Taxonomy Image
Version:6.x-1.x-dev
Component:Views
Category:feature request
Priority:normal
Assigned:NancyDru
Status:closed
Description

Hi,

As the wonderfull views 2 allow to list taxonomy terms, it would be really great to see a taxonomy image views integration to provide the term image as a field views, and, maybe, some filters too...

#1

NancyDru - June 6, 2008 - 15:22

There is Views 1 support. Does it not work in V2?

#2

zmove - June 6, 2008 - 17:17

In V2, I don't see taxonomy image field available... so, I think no ^^

#3

NancyDru - June 6, 2008 - 18:13

Okay. Do you have any idea what they changed and how to fix it? I am not a Views guru by any stretch of the imagination.

#4

NancyDru - June 6, 2008 - 21:24
Title:Views integration» Views2 integration
Status:active» postponed (maintainer needs more info)

#5

zmove - June 7, 2008 - 07:09

Hi,

This is a Link to the views documentation. In this handbook, there is a new section named : Views 2.x module developer API

I hope it will help you

#6

NancyDru - June 7, 2008 - 14:12

Considering my level of Views knowledge that documentation doesn't help me one bit. I need "If you had this, then do this..."

#7

zmove - June 7, 2008 - 19:29

I will try to look through your code and to take informations about the views 2 problem, but I don't know developping for views so it can take a little time, I stay you informed. If a view guru see this post, don't hesitate to bring your help ^^

#8

webchick - June 11, 2008 - 04:46
Status:postponed (maintainer needs more info)» needs work

Disclaimer: I have NO idea WTF I'm doing, but this much shows Taxonomy: Image as a selection as one of the fields. You can't add it, however. :)

AttachmentSize
taxonomy_image-views2-integration-267427-8.patch 1.19 KB

#9

NancyDru - June 11, 2008 - 12:22

Thanks, Angie. Why can't we add it? Is this for Views2? Does it break Views1?

#10

webchick - June 11, 2008 - 14:18

Oh, sorry. I meant you can't add the taxonomy image *field* to a View, because there's some sort of JS error. Meaning, this patch needs lots and lots of work still. ;)

Views 2 isn't remotely compatible with Views 1, but that's fine since there is no (and will be no) Views 1 for Drupal 6, and no Views 2 for Drupal 5.

Oh, and yes. This patch is for Views 2 integration - the 6.x version.

#11

webchick - June 12, 2008 - 02:48

Hm. Getting closer. This is at least showing something close to what it ought to be showing now, with the extra side-benefit of no fatal errors. :)

AttachmentSize
taxonomy_image-views2-integration-267427-11.patch 6.21 KB

#12

webchick - June 12, 2008 - 02:50

Oh. Incidentally, the taxonomy_image.views.inc is a new naming convention standard enforced by Views 2. I didn't just break out the Views integration code for the heck of it. ;)

#13

webchick - June 12, 2008 - 04:24
Status:needs work» needs review

Holy crap, I think it's working!

I tested this by creating a view called "Topic List" and gave it two fields: Taxonomy: Term and Taxonomy: Term Image. I tested both with and without Imagecache, and all seems ok. Would love an extra set of eyes or 3 on it. :)

I tried to comment the crap out of the file so that the next poor person doesn't waste 4 hours trying to figure out what's going on. :P

AttachmentSize
taxonomy_image-views2-integration-267427-13.patch 6.08 KB

#14

NancyDru - June 12, 2008 - 12:52

Thank you very much, Angie. I guess now I need to actually try out Views 2.

#15

vatavale - July 3, 2008 - 20:23

It seems that this patch does not work for me.
I have applied only last patch (number 13), it is correct?
Additional fields (taxonomy section) in Views 2 do not appear.

Drupal 6.2

Views 6.x-2.0-rc1
Taxonomy Image 6.x-1.3 (with patch №13)
- Taxonomy Image Blocks on
- Taxonomy Image Link Alter on
- Taxonomy Image Node Display on
CCK 6.x-2.x-dev

PHP 5.2.6
MySQL 4.1.22

In http://www.designcapital.ru/temp/after_patch.rar -- files of module after apply patch.
Please, check up, whether correctly I have applied a patch?
I use patch.exe (from gnuwin32) on Vista64 system by command "patch.exe < taxonomy_image-views2-integration-267427-13.patch --binary" and it seems all has passed well.

#16

zajatz - August 24, 2008 - 09:35

And what about "Taxonomy: Term image" showing when view type is Node? Term image is shown when View type is set to Term; it will be pleasing to see Term image on Node type.

#17

NancyDru - August 24, 2008 - 11:15

I have 20+ modules to support; I will be getting to this, please be patient.

#18

NancyDru - August 27, 2008 - 14:08

@webchick: PHP Fatal error: Class 'views_handler_field' not found in C:\\www\\drupal-6\\sites\\all\\modules\\contrib\\taxonomy_image\\taxonomy_image_views.inc on line 42, referer: http://d6/admin/build/views/edit/weblinks_test

#19

NancyDru - August 27, 2008 - 15:42

If I move the file to the views/modules folder (renamed with dot), there is no error, but also no evidence that it is even found.

#239711: Class 'views_handler_field_node' not found

#20

NancyDru - August 27, 2008 - 16:10
Status:needs review» needs work

#21

NancyDru - August 27, 2008 - 17:45

#22

NancyDru - August 27, 2008 - 19:13

According to #300731: taxonomy_image.views.inc is not working, we may not be able to provide this function with Views2.

#23

NancyDru - August 28, 2008 - 15:14
Status:needs work» fixed

Thanks to Mooffie it appears to be working now. Committed to the -dev version to be tested.

If there are problems, please open a new issue.

#24

mooffie - August 28, 2008 - 15:46
Status:fixed» active

There's one yet occurrence of `$values->tid` in render() that needs to be replaced with `$tid`.

#25

NancyDru - August 28, 2008 - 15:49
Assigned to:Anonymous» NancyDru
Status:active» fixed

Thanks, Mooffie.

#26

chasz - August 30, 2008 - 19:47
Version:6.x-1.x-dev» 6.x-1.3
Status:fixed» active

is it fixed in this version for view2?? because i have switched on fields and not nodes, and i cant see the field for taximage

or am i doing something wrong??

#27

NancyDru - August 30, 2008 - 19:56

Release 6.x-1.3 has a date of "2008-Jun-02". Release 6.x-1.x-dev has a date of "2008-Aug-28". Comment #28 above shows "fixed" on "August 28, 2008." That seems to indicate that this fix would be in 6.x-1.x-dev. Testing that version and reporting your results would be appreciated.

#28

NancyDru - August 30, 2008 - 19:56
Status:active» fixed

#29

chasz - August 30, 2008 - 20:14
Version:6.x-1.3» 6.x-1.x-dev

fixed good work thank

am a noob :D

#30

NancyDru - August 30, 2008 - 20:20

I saw that; welcome to drupal.org. That's why I tried to explain how one might figure out where to find a fix. I hope it didn't sound sarcastic.

#31

Anonymous (not verified) - September 13, 2008 - 20:22
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.