Download & Extend
Issues

Long lists of recipient emails in admin/build/contact does not wrap

Posted by joachim on June 6, 2008 at 1:05pm
Project:Drupal core
Version:8.x-dev
Component:contact.module
Category:bug report
Priority:normal
Assigned:Dave Reid
Status:needs review

Issue Summary

The list of recipient emails on admin/build/contact isn't broken up with spaces.
This means it doesn't wrap in the browser. With more than two or three addresses, the operation links get moved off screen and under sidebars and the page becomes unusable.

Login or register to post comments

Comments

#1

Posted by Dave Reid on April 20, 2009 at 8:31pm
Title:long list of recipient emails makes contact admin page unusable» Long lists of recipient emails in admin/build/contact does not wrap
Version:6.2» 7.x-dev
Status:active» needs review

Patch attached for review.

AttachmentSizeStatusTest resultOperations
267492-contact-long-email-list-D7.patch768 bytesIdlePassed: 10800 passes, 0 fails, 0 exceptionsView details | Re-test

#2

Posted by mcrittenden on April 21, 2009 at 4:06am
Status:needs review» needs work

Patch does a good job fixing the issue at admin/build/contact but the list still fails to wrap at admin/build/contact/edit/%n ...we either need to also fix the issue there or change that textarea to a text input (no point in having a textarea when everything's being put on one line).

#3

Posted by Dave Reid on April 21, 2009 at 4:52am

I'm thinking that we should probably do it the Drupal(tm) way and have them list e-mail address, one per line instead of separated by commas with no spaces. That's just silly.

#4

Posted by Dave Reid on April 21, 2009 at 5:23am
Status:needs work» needs review

Revised patch that uses newlines instead of commas. Don't have time to test the upgrade path, but will check tomorrow. Peer review welcomed.

AttachmentSizeStatusTest resultOperations
267492-contact-long-email-list-D7.patch4.58 KBIdleFailed: 10764 passes, 36 fails, 0 exceptionsView details | Re-test

#5

Posted by System Message on April 21, 2009 at 5:40am
Status:needs review» needs work

The last submitted patch failed testing.

#6

Posted by Dave Reid on October 8, 2009 at 4:49pm
Assigned to:Anonymous» Dave Reid

#7

Posted by Jody Lynn on January 9, 2011 at 1:16am
Status:needs work» needs review

I rerolled it

AttachmentSizeStatusTest resultOperations
267492-7.patch5.39 KBIdlePASSED: [[SimpleTest]]: [MySQL] 31,507 pass(es).View details | Re-test

#8

Posted by mcrittenden on January 10, 2011 at 2:13pm

Does this need to be pushed to 8.x now?

#9

Posted by joachim on January 11, 2011 at 8:53am

Perhaps Dave Reid's patch to do it the Drupal(tm) way has to be pushed to 8, but we still need to fix the output bug for 7. Ironic that the Drupal way is not the Drupal way ;)

#10

Posted by joachim on November 23, 2011 at 4:51pm
Version:7.x-dev» 8.x-dev

Changing version.

nobody click here