Closed (fixed)
Project:
Page Title
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Jun 2008 at 13:48 UTC
Updated:
16 Mar 2009 at 10:19 UTC
The attached patch implements Zen's hook_preprocess_page() making Zen based subthemes automatically benefit from this module.
| Comment | File | Size | Author |
|---|---|---|---|
| page_title_for_zen.patch | 465 bytes | TBarregren |
Comments
Comment #1
nicholasthompsonTechnically its good practice to wrap the function in an "if (module_exists('page_title))" check first. If you dont then if you admin decides to disable the module then the entire site goes down with a "function not found" type error.
Thanks for the patch though! I'll commit this to the documentation once done.
Comment #2
johnalbinActually, a module_exists() check is unnecessary in this case. Zen-based themes will call any HOOK_preprocess_page functions that are implemented by modules. So, if page_title is disabled (or not installed), it won't call page_title_preprocess_page(); and if page_title is enabled, page_title_page_get_title() is available. :-)
(Btw, Zen's usage of HOOK_preprocess_page is a back-port of a D6 theme system feature.)
Thomas, I apologize for not having time to do a review right now. But the patch looks good.
Comment #3
nicholasthompsonOhhh I see - sorry, I thought that was a template hook and not a module hook.
I'll commit this into the latest Page Title 2.0...
Comment #4
nicholasthompsonFixed in Page Title 2.0 Dev as of now - will be in ALPHA7 soon.
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #6
venkat-rk commentedDid this make it into the tarball for 5.x-2.0?
I am using it with drupal 5.16 and the Zen Classic sub-theme, but I don't see the field for controlling the page title anywhere on the node.