The attached patch changes some double quotes to single quotes and releases some embedded variables that I came across while updating some functions in it...

CommentFileSizeAuthor
#2 common.inc_.patch5.27 KBmrharolda
common.inc_.patch5.67 KBmrharolda

Comments

gpk’s picture

gpk commented
Status: Needs review » Needs work

"Host: $host" is very much OK. See http://drupal.org/node/30785.

mrharolda’s picture

mrharolda commented
Status: Needs work » Needs review
StatusFileSize
new common.inc_.patch5.27 KB

Reverted the "Host: $host" definition...

Please review the attached patch (again).

gpk’s picture

gpk commented

Actually there are more that could benefit from the " syntax instead of ' ....

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

not ok:

- "profiles/$profile/$directory"
- "$config/$directory"
- "$prefix.$field"
- '} SET $query WHERE ' (watch out!)

from this patch. The first 3 should be left alone; sometimes readability has higher priority.
Everything else is good to go.

casey’s picture

casey commented

No longer applies.

casey’s picture

casey commented
Status: Needs work » Closed (fixed)

Feel free to reopen if you disagree on closing.