Annotate and Printer Friendly

SomebodySysop - June 8, 2008 - 17:38
Project:Annotate
Version:5.x-1.2
Component:Code
Category:feature request
Priority:normal
Assigned:clemens.tolboom
Status:closed
Description

I have Annotate installed on a 5.x system.

When a user with "read annotation" and "create annotation" permissions clicks on "Printer Friendly", the "Annotations" section of the resulting printer friendly page includes "Input format" and "Visibility" node form fieldsets as well as the "Update" button. I would think that in the "Printer friendly" version of a node, we should only see the "Notes" for "Annotations".

Any suggestions?

#1

clemens.tolboom - June 8, 2008 - 18:34
Category:support request» feature request

You are quite right that this should be rendered differently. If you could give me some code example how printer friendly works that would be great!

Thanks for the suggestion

#2

clemens.tolboom - June 10, 2008 - 08:21
Status:active» postponed (maintainer needs more info)

#3

SomebodySysop - June 10, 2008 - 18:41

Try this patch on 5.x-1.1 release. Should fix the problem.

#4

SomebodySysop - June 10, 2008 - 18:44
Status:postponed (maintainer needs more info)» needs review

Can't seem to upload the patch. If not attached here, then get it from here: http://www.scbbs.com/system/files/annotate.module.5.x-1.1.patch

AttachmentSize
annotate.module.5.x-1.1.patch 2.26 KB

#5

clemens.tolboom - June 14, 2008 - 20:16

I don't think it should be a text area in printer friendly mode. It should either be plain text or not showed at all.

What do you (everybody!) think?

#6

SomebodySysop - June 15, 2008 - 00:17

How do you render 'plain text' using the form api? I couldn't figure out how to do it.

#7

clemens.tolboom - June 15, 2008 - 14:26
Version:5.x-1.1» 5.x-1.x-dev
Status:needs review» active

I decide to place ALL allowed annotations on the printer friendly page ... that is the content of the 'Annotation' tab is merged into the printer friendly page.

My motivation is that when people want to print the page they want all content related to the page. If I'm wrong please let me know. I will commit this solution into the dev version.

#8

SomebodySysop - July 20, 2008 - 18:35

Have you looked at the "printer friendly" output from annotate? It puts the actual annotation into a small box (that must be scrolled to see a long annotation). It also display the "Input format" and "Visibility" settings as well as the "Update" button. How do we get rid of all that and just show the formatted text of the annotation itself in printer-friendly mode?

AttachmentSize
annotatePrinterFriendly.jpg 69.67 KB

#9

clemens.tolboom - August 8, 2008 - 10:24
Assigned to:Anonymous» clemens.tolboom

The changes I made where done in the dev version. I will create an official release from it.

#10

clemens.tolboom - August 8, 2008 - 11:22
Version:5.x-1.x-dev» 5.x-1.2
Status:active» fixed

#11

clemens.tolboom - August 8, 2008 - 12:55
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.