Custom logo uploading broke. System_settings_save() was doing a drupal_goto() before the code to save the logo got executed.

CommentFileSizeAuthor
system.module_4.diff1.95 KBdrumm

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented

I inspected the code for 4.6 and this appears to be a problem there too.

dries’s picture

dries commented

I tested this patch and noticed a couple things:

1. The bluemarine theme did not pick up my custom logo. It took me 5 minutes to figure out.

2. When I upload my logo, the 'custom logo' path did not change. Combined with (1) this makes for a pretty bad experience.

When I switched theme, this patch seems to fix an important bug. Just wondering if you could look into (1) and (2) before this gets committed? Clearly, there is room for improvement here. If you don't have time for this, I'll commit your patch as is.

drumm’s picture

drumm
he/him
Location NY, US
commented

1. Hmm.. logo uploads always go to files/logo.png so it is possible that the browser cached it. It is also possible that some logic in the theme system got messed up. Either way I can;t actually reproduce it over here.

2. Lets separate UI fixing from bug fixing and do that later. Anyone got some mockups or something?

drumm’s picture

drumm
he/him
Location NY, US
commented

1. I figured out how to reproduce the behavior Dries found. Set a logo for a single theme, such as the one you are using. Set a logo in the global theme settings. The globally set logo does not appear since the theme-specific logo is overriding it.

I think fixing that is outside of the scope of this issue.

Steven’s picture

Steven commented
Status: Needs review » Fixed

Fixed in 4.6 and HEAD.

Anonymous’s picture

(not verified) commented
drumm’s picture

drumm
he/him
Location NY, US
commented
Version: » 4.6.0
Status: Fixed » Closed (fixed)
basicmagic.net’s picture

basicmagic.net commented

hello- just downloaded and installed the new 4.6.3 tarball-

this issue appears to still be present-

drove me crazy for a few hours until i found this post-
but unfortunately it still appears to be malfunctioning exactly the same way-

i can not load any new logo images to displace the default logo-
on any of the themes.

could someone please take a look at this and respond-
as i am surely not the only one with this problem-
using the default brand new tarball of 4.6.3 with no changes.

thanks-
as always

vincent

liquidcms’s picture

liquidcms commented

this ever get fixed??... i have 4.6.5 and can't upload a logo.

permissions on folder are set for everyone to have access to files folder

liquidcms’s picture

liquidcms commented

and i just tried doing same on my 4.7 install and it works fine.. with all the saem default permissions set.. so i guess a bug in 4.6.5.. i guess i'll try picking up latest cvs of 4.6 ???