Page titles not working for node override pages

Confirming. If more than one content-type is enabled, and at least one content-type has an "own" display, the node's title for this separate ("own") content-type is

1) not output at all, even if both a Panel title (in settings) and Display title (in layout settings) is set.

2) output as page title AND page heading ($title) if a Display title (in layout settings) is configured, but "Hide title?" is NOT enabled.

3) replaced by the term "View" and output as page title AND page heading if a Display title is configured and "Hide title?" is enabled.

btw: #213751: $node->title removed from template variables does not resolve this issue.

I've vardumped my way through Panels a bit now - some facts:

a) panels_page_view_page() retrieves and sets the correct context, keywords, and title in line 786:

drupal_set_title(filter_xss_admin(panels_page_get_title($panel_page, 'page', '')));

b) Even if I configure the Panel to disable regular Drupal regions, and also even if I disable all panes of this Panel (in this "own" display), "View" is still output.

So, erm, that would basically mean that something else actually overrides the page title.

meh... for my case, I was a bit confused with the Page Title module, and now found out that setting a page title without setting a title is simply not possible. So I'm overriding the title for certain content-types in my theme now.

Nevertheless... from your comment in #2:

In the Title field for each content type you must enter: %node. Even though the help text seems to indicate that you can leave it blank, you can't.

This particular bug is true -- Panels won't use the default display title in layout settings, nor will it use the Panel Page's title.

Also, even though it would seem that checking "Hide title" would simply prevent the display of the $title on the page, it actually replaces the node's title with some other value (in my case: View) and continues to displays it. I think this is a bug.

The reason why "View" is displayed as title is quite simple: The menu item for 'node/#', resp. 'node/#/view', registers the title "View" as menu item title. Drupal automatically sets the menu item title as page title if no other title has been set via drupal_set_title().

Thanks Zach Harkey for your solution. It works for me.

But how to hide the node title in node content, because we now have two titles in page (one for page title and one for node title)

Thanks Zach Harkey. It's works well for me. I think that helpful information in this post must be include in the panel documentation.

subscribing

I had the same problem after updating to beta5 and then making some changes. I tracked it down in this patch, which is the code equivalent to Zach's workaround. Apparently the layout settings title is being set now even though it's empty, which is having this awful effect.

This is also true for titles set by panel arguments, which are also completely ignored.

For example, create a panel with the URL node/%/foo and give it a default title of "Foo panel". Then add Node ID as an argument and set the page title to Foos of %node. The expected result would be the title of the argument node inserted into the page title, overriding the panel default title.

This seems to be not happening because of this logic (basically the same part Lynn has been identified):

  if ($panel_page->did == $panel_page->display->did || $panel_page->display->did == 'new') {
    return !empty($panel_page->display->title) ? $panel_page->display->title : $panel_page->title;
  }
  elseif (isset($panel_page->display->title)) {
    return $panel_page->display->title;
  }

First, it seems, when viewing a panel page, the condition
$panel_page->did == $panel_page->display->did
is always true (at least this was the case for me), resulting in either the display->title or the default title to be returned. Since display->title was empty, the default panel title was always returned, which is wrong.

Looking down the code in that function reveals that the default panel title is already returned at the very end of it, when all other possibilities to set a title yielded no results. This seems to be correct behavior, given the static nature of the default title.

However, if we remove the default panel title from above code, then the complete first if-clause can be nuked, and display->title returned whenever it is set (honestly I have no idea when this is the case).

Ok, sun just stopped by and explained me the mysteries he had with display titles and multiple displays recently. Together we discussed this, and came to the conclusion that titles should actually be set in the reverse order in which they are set (look at the local tasks to understand it!). Thus, 1. context, 2. layout (called display internally), and 3. general settings.

We put together a new patch where the display title is now moved after probing available contexts, and added some comments about our findings.

I tested smk-ka's patch in #15 thoroughly now, using the following test plan:

1. Created a panel for path "node/%" and added the "Node ID" argument to contexts, enabled the Panel for all content-types, enabled "Use different default display", and enabled an "own display" for two of those content-types.
2. Set up the following title configuration:
   • Settings title: "Panel title"
   • Layout settings title in tab "Default": "Default display title"
   • Layout settings title in tab "Node ID 1 Default": "Default argument display title"
   • Layout settings title in tab "Node ID 1 Type1": "Type1 argument display title"
   • Layout settings title in tab "Node ID 1 Type2": "Type2 argument display title"
   • Context settings title for argument "Node ID": "Context title"
3. Created node/1 of content-type Type1; node/2 of content-type Type2.
4. Visited node/1 and "Context title" was displayed as page title.
5. Enabled "hide title" option in layout settings for "Node ID 1 Type1".
6. Visited node/1 and no page title was displayed.
7. Disabled "hide title" option in layout settings for "Node ID 1 Type1".
8. Removed/blanked out context settings title for argument "Node ID".
9. Visited node/1 and "Type1 argument display title" was displayed.
10. Visited node/2 and "Type2 argument display title" was displayed.
11. Enabled "hide title" option in layout settings for "Node ID 1 Type1".
12. Visited node/1 and no page title was displayed.
13. Disabled "hide title" option in layout settings for "Node ID 1 Type1".
14. Enabled "hide title" option in layout settings for "Node ID 1 Type2".
15. Visited node/2 and no page title was displayed.
16. Disabled "hide title" option in layout settings for "Node ID 1 Type2".
17. Removed/blanked out layout settings title in tab "Node ID 1 Type1".
18. Visited node/1 and "Panel title" was displayed.
19. Enabled "hide title" option in layout settings for "Node ID 1 Type1".
20. Visited node/1 and no page title was displayed.
21. Disabled "hide title" option in layout settings for "Node ID 1 Type1".
22. Created node/3 of an unrelated content-type.
23. Visited node/3 and "Default argument display title" was displayed.
24. Enabled "hide title" option in layout settings for "Node ID 1 Default".
25. Visited node/3 and no page title was displayed.
26. Disabled "hide title" option in layout settings for "Node ID 1 Default".
27. Changed the panel path from "node/%" to "node".
28. Visited node and "Default display title" was displayed.
29. Enabled "hide title" option in layout settings in tab "Default".
30. Visited node and no page title was displayed.
31. Disabled "hide title" option in layout settings in tab "Default".
32. Removed/blanked out layout settings title in tab "Default".
33. Visited node and "Panel title" was displayed.
34. Enabled "hide title" option in layout settings in tab "Default".
35. Visited node and no page title was displayed.
36. Disabled "hide title" option in layout settings in tab "Default".

Thus, expected behavior in a complex override setup.

Subscribing, trying out above approach! greetings, Martijn

I'll take a look at this patch presently, and while I'm very much hoping that I can come to a similar conclusion, my history with this function doesn't have me all too hopeful. But I'll report back here once I've got something concrete.

Patch does not seem to apply.

Rerolled.

I am trusting sun's testing here, as that's a fairly long testing plan. COmmitted, but I'd appreciate it if people would keep an eyeon this issue for awhile.

Hi Guys,

I am applying the same panel layout to 3 different content types.

When I set the Page Title on the Layout Settings screen, Default panel to %node it does not work.

It just brings in the site name.

When I set the Page Title on the Layout Settings screen inside each content type to %node then it does work, but I think this is still a bug, as the default setting should apply to all of them.

Any ideas?

Cheers,
G

@giorgio79: There are two default layout settings tabs - one is called "Node ID # Default", the other one "Default". Did you ensure that you entered %node in the first one? Also, are you working with 5.x-2.x or beta5? This issue is fixed in current 5.x-2.x development snapshot only.

Thanks Sun I have 5.x-2.x or beta5. I was looking for the 5.x-2.x dev snapshot but did not find a download link on the project page.

Will try to poke around svn.

I guess this is fixed then.

See http://drupal.org/node/128199 for the current development snapshot. If you can wait for RC1, you are advised to wait.

If you're still having trouble, and by any chance using more then one language, and maybe don't have a translation for these nodes your trying to display correctly - check this: http://drupal.org/node/296919 .