i'm trying to make use of the new menu handler and finding that the old code doesn't really play well with it. looking like it'll be rewrite before it's all said and done.

CommentFileSizeAuthor
#10 peek_268676.patch59.22 KBdrewish
#9 peek_268676.patch59.2 KBdrewish
#7 peek_268676.patch46.43 KBdrewish
#8 peek_268676.patch57.92 KBdrewish
#6 peek_268676.patch56.81 KBdrewish
#5 peek_268676.patch57.26 KBdrewish
#4 peek_268676.patch56.07 KBdrewish
#2 peek_268676.patch46.82 KBdrewish
peek_d6.patch45.92 KBdrewish

Comments

adixon’s picture

adixon commented

thanks for this, i wasn't sure anyone cared. Back later this week.

drewish’s picture

drewish commented
StatusFileSize
new peek_268676.patch46.82 KB

getting closer

drewish’s picture

drewish commented

that patch is totally broken. i didn't realize that you didn't have HEAD and DRUPAL-5 synced up... i'm tempted to just start the update over so i'm working off the current code.

drewish’s picture

drewish commented
StatusFileSize
new peek_268676.patch56.07 KB

went ahead and manually merged in your changes. this still needs work but it's turning into a rewrite.

drewish’s picture

drewish commented
Status: Needs work » Needs review
StatusFileSize
new peek_268676.patch57.26 KB

cleaned up the table builder so it's a bit easier to understand and made it sortable. it really needs to have a pager added and use the $limit property that's being passed to it.

there's probably still some broken stuff but it seems basically usable at this point.

drewish’s picture

drewish commented
StatusFileSize
new peek_268676.patch56.81 KB

realized that the whole drupal mail api had changed in D6 and so i had to rework that. lots more cleanups.

drewish’s picture

drewish commented
StatusFileSize
new peek_268676.patch46.43 KB

better email messages, probably some other stuff too--i don't quite remember what i was working on today.

update: this is missing some files.

drewish’s picture

drewish commented
StatusFileSize
new peek_268676.patch57.92 KB

Added a new per-node peek option: Enabled. Now you can force all nodes of a type to be peekable.

drewish’s picture

drewish commented
StatusFileSize
new peek_268676.patch59.2 KB

The client needed a note on the peek to describe why they were being granted access and what to look at.

drewish’s picture

drewish commented
StatusFileSize
new peek_268676.patch59.22 KB

fixed an XSS hole in my last patch.

drewish’s picture

drewish commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Fixed

adixon added me as a maintainer so i went ahead and committed this. i'll do any future fixes as separate issues.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.