ActiveMenu compatibility with certain themes

najibx - June 10, 2008 - 12:35
Project:Active menus
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active
Description

the "+" button is not duplicated with arrow. any guide to put this in place?

#1

andregriffin - June 10, 2008 - 17:27

The way i re-engineered the menu system was so that all menu items were the full width of the menu, regardless of indentation. This allowed for the alternating row colors, full block links etc.

I cannot see how to change the icon to be set as a background image and still be clickable. There is a garland.css in the theme folder in the activemenu module folder. If you rename that to framework.css and upload it to the same location, you can see how it could work, but the + and - icons are no longer clickable.

#2

andregriffin - June 12, 2008 - 23:00
Status:active» postponed (maintainer needs more info)

#3

najibx - June 13, 2008 - 07:43

adding a framework.css (copy from garland.css) in activemenu/theme only partially solve the issue. The active menu features collapse/uncollape is now gone. bTW, the + and - is clikable.

however, "ArtistsC01" is doing perfectly handling this issue without putting anything in the activemenu/theme ?

anyone care to re-engineer ...

#4

andregriffin - June 13, 2008 - 21:40

Here is as far as I got with it. The styling is about right, but only the current active menu functions properly. And something looks kinda weird in IE7.

Make this a framework.css in the activemenu theme folder.

li.activemenu-processed {
  cursor: pointer;
  cursor: hand;
  min-width: 0; /* Harmless hack to give IE7 hasLayout */
}

li.activemenu-processed ul {
  cursor: default;
}

li.activemenu-processed.expanded {
  background: transparent url(../minus.png) no-repeat;
}

li.activemenu-processed.collapsed {
  background: transparent url(../plus.png) no-repeat;
}

li.activemenu-processed.loading {
  background: transparent url(../status-active.gif) no-repeat;
}

li.collapsed ul {
  display: none;
}

ul.menu li.activemenu-processed{background-position:.3em .6em;list-style-image:none;list-style-type:none;margin:0}
ul.menu li ul li.activemenu-processed{background-position:1.5em .6em}
ul.menu li ul li ul li.activemenu-processed{background-position:2.7em .6em}
ul.menu li ul li ul li ul li.activemenu-processed{background-position:3.9em .6em}

ul.menu li.activemenu-processed a{margin:.1em 0 .1em 1.5em;padding-left:0}
ul.menu li ul li.activemenu-processed a{margin-left:2.7em;padding-left:0}
ul.menu li ul li ul li.activemenu-processed a{margin-left:3.9em;padding-left:0}
ul.menu li ul li ul li ul li.activemenu-processed a{margin-left:5.1em;padding-left:0}

ul.menu li.activemenu-processed li.leaf {padding-left:1.2em;}

#5

Aren Cambre - July 10, 2008 - 01:55

subscribe. I have Activemenu running, but the +/- appears in its own column to the left of the menu items, and because it's in its own column, it does not indent--just a vertical column.

This is a great theme, by the way.

#6

Aren Cambre - July 7, 2008 - 03:47
Version:6.x-1.8» 6.x-1.9

Update version.

#7

Aren Cambre - July 30, 2008 - 02:07
Version:6.x-1.9» 6.x-1.11
Category:support request» bug report

Updating version.

And changed to a bug since this affects out-of-the-box functionality. If it's an Activemenu bug, this should be transferred.

#8

Aren Cambre - October 3, 2008 - 02:50
Priority:normal» critical

Changing to critical because it significantly impacts use of the theme.

#9

andregriffin - October 3, 2008 - 09:17
Priority:critical» normal

A supplementary menu utility module not being supported "significantly impacts the use of the theme"? That's rather excessive. I think I'll keep it at the priority level I had it set at before, if that's ok with you...

If no one else takes a shot at fixing this, I'll revert the menu system to the "garland" style, which would possibly remove the zebra striping and full width block links features from the next Framework release.

#10

andregriffin - October 10, 2008 - 06:58

I'll review this issue to try to build the menu in a format favored by this module, while keeping the visual format of the menu the same.

I hope to resolve this in release 2.1.

#11

andregriffin - October 11, 2008 - 20:54
Status:postponed (maintainer needs more info)» fixed

legacy menu/list support is now included in the 2.1 CSS file. Directions are given to comment out default list/menu/zebra coloring, then just uncomment the legacy list/menu code.

#12

Aren Cambre - October 11, 2008 - 22:23
Status:fixed» active

Still not working. +/- are appearing on the left hand side in their own column.

AttachmentSize
menu.png 122.21 KB

#13

andregriffin - October 12, 2008 - 01:16

It appears you enable legacy list support. For Framework 6.x-2.1, please see line 532 in style.css

It involves a simple uncommenting and commenting out of code.

#14

andregriffin - October 11, 2008 - 22:31

I realize that this may be an unintuitive solution, but it is a compromise for those who want the more fully supported, zebra colored lists, or the legacy lists that is required by some modules.

#15

andregriffin - October 11, 2008 - 22:39

Here is an example of how you could comment the code. The following is commented for legacy support.

/* lists /
dl { margin: .5em 0 1em; padding: 0; }
dl dd { margin: 0 0 .5em 1.5em; }
ol { margin: .5em 0 1em; padding: 0 0 0 1.5em; }
ol li { margin: .15em 0 .15em .5em; padding: 0 0 .2em; }
ol ul li { margin-left: .5em; padding: 0 0 .2em 1.5em; }
ul { margin: .5em 0 1em; padding: 0; }
.item-list ul { margin: .35em 0 0 -.5em; padding: 0; }
.item-list ul ul { margin-left: 0; }
ul li, ul li.leaf, .item-list ul li { background: transparent url(images/menu-leaf.gif) no-repeat 1px .35em; list-style-image: none; list-style-type: none; margin: .15em 0 .15em .5em; padding: 0 0 .2em 1.5em; }
ul li.expanded { background: transparent url(images/menu-expanded.gif) no-repeat 1px .35em; }
ul li.collapsed { background: transparent url(images/menu-collapsed.gif) no-repeat 0 .35em; }
ul li.leaf a, ul li.expanded a, ul li.collapsed a { display: block; }
ul.inline li { background: none; margin: 0; padding: 0 1em 0 0; }
ul ol li { background: none; list-style-type: decimal; margin-left: 2em; padding: 0 0 .2em; }
ul ul li { margin-left: 2em; }

/* menu /
ul.menu { margin: 0; padding: 0; }
ul.menu li { background-position: .3em .6em; list-style-image: none; list-style-type: none; margin: 0; padding: .1em 0 .1em 0; }
ul.menu li a { padding: .1em 0 .1em 1.5em; }
ul.menu li ul li { background-position: 1.5em .6em; }
ul.menu li ul li a { padding-left: 2.7em; }
ul.menu li ul li ul li { background-position: 2.7em .6em; }
ul.menu li ul li ul li a { padding-left: 3.9em; }
ul.menu li ul li ul li ul li { background-position: 3.9em .6em; }
ul.menu li ul li ul li ul li a { padding-left: 5.1em; }
ul.menu li.expanded { padding-bottom: 0; }
ul.menu li.expanded ul { margin-top: .1em; }

/* menu zebra coloring /
ul.menu li { border-bottom: 1px solid #d4e7f3; padding: .2em 0 .2em 0; }
ul.menu li a { padding: .2em 0 .2em 1.5em; }
ul.menu li.odd { background-color: #fff; }
ul.menu li.even { background-color: #edf5fa; }
ul.menu li.expanded { background-color: #d4e7f3; border: none; padding-bottom: 0; }
ul.menu li.expanded ul { border-bottom: 3px solid #d4e7f3; border-top: 1px solid #b4d7f0; margin-top: .2em; }
*/

/* legacy list support -- MUST COMMENT OUT [LISTS/MENU/ZEBRA COLORING] ABOVE -- remove brackets around asterisk to enable -- */
ul { margin: .5em 0 1em; padding: 0; }
ol { margin: .75em 0 1.25em; padding: 0; }
ol li, ul li { margin: .4em 0 .4em .5em; }
ul.menu, .item-list ul { margin: .35em 0 0 -.5em; padding:0; }
ul.menu ul, .item-list ul ul { margin-left: 0; }
ol li, ul li, ul.menu li, .item-list ul li, li.leaf { margin: .15em 0 .15em .5em; }
ul li, ul.menu li, .item-list ul li, li.leaf { background: transparent url(images/menu-leaf.gif) no-repeat 1px .35em; list-style-image: none; list-style-type: none; padding: 0 0 .2em 1.5em; }
ol li { margin-left: 2em; padding: 0 0 .3em; }
ul li.expanded { background: transparent url(images/menu-expanded.gif) no-repeat 1px .35em; }
ul li.collapsed { background: transparent url(images/menu-collapsed.gif) no-repeat 0 .35em; }
ul li.leaf a, ul li.expanded a, ul li.collapsed a { display: block; }
ul.inline li { background: none; margin: 0; padding: 0 1em 0 0; }
dl { margin: .5em 0 1em 1.5em; }
dl dd { margin: 0 0 .5em 1.5em; }
/* end legacy list support */

#16

andregriffin - October 11, 2008 - 22:50
Version:6.x-1.11» 6.x-2.1

#17

andregriffin - October 12, 2008 - 01:06

Sorry, upon further inspection, an activemenu theme needs created.

Create a file called framework.css and place in into the "..modules/activemenu/theme" directory.

li.activemenu-processed { cursor: pointer; cursor: hand; min-width: 0; }
li.activemenu-processed ul { cursor: default; }
li.activemenu-processed.expanded { background: transparent url(../minus.png) no-repeat 0px .35em; }
li.activemenu-processed.collapsed { background: transparent url(../plus.png) no-repeat 0px .35em; }
li.activemenu-processed.loading { background: transparent url(../status-active.gif) no-repeat 0px .35em; }
li.collapsed ul { display: none; }

#18

andregriffin - October 12, 2008 - 01:21
Status:active» fixed

Confirmed fix: Enable Legacy support in style.css and create the framework.css as noted above.

#19

Aren Cambre - October 12, 2008 - 03:27
Category:bug report» support request
Status:fixed» active

Thanks.

I see the thing about legacy support. Does this mean that ActiveMenu needs to be updated? Or does this mean that Framework is shipped in a weird mode?

In other words, why is this not a theme bug?

#20

andregriffin - October 12, 2008 - 04:41
Status:active» fixed

I completely rebuilt the way the ordered and unordered lists were formatted, allowing for better support of lists within lists (ex: ordered within an unordered and vice versa) as well as allowing the coloring of the links (in this case, the zebra coloring).

The reason background coloring would not look good in the "legacy" mode, is that each sub-link is indented, making each link a different width. The default Framework sub-links just have the appearance of indention, achieved through left padding instead of margin, allowing for the entire width of the links to remain constant to make for a good looking styled list.

This is not a bug, it is a design choice. Now that both formats are supported, there should be no problems. There are only a few cases, as with activemenu, that legacy lists should be required due to that module being designed for a certain list format.

Framework with legacy support turned on requires the same theme file for activemenu that Garland does. If you wanted, you could rename garland.css found within "..modules/activemenu/theme" to framework.css, and it would work.

If I found that no one cares about more complex combinations of list support and coloring options, I would scrap the code and ship it in "legacy" mode by default.

I feel I've explained quite enough on this issue, and since it can be put in working order with little effort out of the box, I consider this issue FIXED.

Thanks for your interest Aren and being patient with this issue. I hope you understand why things are the way they are.

#21

Aren Cambre - October 13, 2008 - 02:52
Project:Framework» Active menus
Version:6.x-2.1» 6.x-1.x-dev
Category:support request» feature request
Status:fixed» active

Thank you. That's fine. I'm just trying to discern if there is room for improvement in the ActiveMenu module.

I have transferred this as a feature request to ActiveMenu to see if they have any thoughts on improvement for ActiveMenu.

#22

Aren Cambre - October 13, 2008 - 14:17
Title:support for JS activemenu» ActiveMenu compatibility with certain themes

Renaming title to be appropriate for ActiveMenu support queue.

#23

nedjo - October 24, 2008 - 04:49

I'd welcome patches to improve activemenu theme compatibility.

 
 

Drupal is a registered trademark of Dries Buytaert.