Hi. I am using D5.7 + Panels 5.x-2.0-beta5.
1) I create a panel node
2) I do set a CSS ID value in the edit form

The specified CSS ID does not appear anywhere in the HTML code of the generated page.

--
GP

CommentFileSizeAuthor
#6 panels_node_patch.txt714 bytesmleicester

Comments

dccircuit’s picture

dccircuit commented
Version: 5.x-2.0-beta5 » 5.x-2.0-rc1a

I am also experiencing this in 5.x-2.0-rc1a (Drupal version: 5.9)

sdboyer’s picture

sdboyer commented

What layout are you (both) using when this problem occurs?

gp.mazzola’s picture

gp.mazzola commented

Hi sdboyer,
I am using the flexible layout. I gave an CSS ID to the whole panel node, and also to panes inside the panel. Panes'IDs come out, but not the panel's one.

On another website, I am using the latest rc version, and as noted by dccircuit, the same problem. Even here flexible layout.
I tried switching through themes, but the problem persists. So it does not seem theme related.

Let me know if I could be of more help.
I could try creating panels in differents layouts and see if the problem is layout indipendent.

Ciao,
GP

sdboyer’s picture

sdboyer commented

Yeah, it's definitely not going to be theme related. If you could try switching layouts and see if css id appears, that'd be great...

gp.mazzola’s picture

gp.mazzola commented

HI sdboyer. I just made a test on the more recent website D5.10 + panels 5.x-2.0-rc1a + Graland theme

1) Create a panel node

2) Set and ID for the node

3) switched through every available layout

==> the CSS ID set for the panel does never appears

Only css ID and classes for panes show up.

Ciao,
GP

mleicester’s picture

mleicester commented
StatusFileSize
new panels_node_patch.txt714 bytes

I think the problem is in line 297 of panels_node.module.

It reads:
$display->css_id = $node->panel_node['css_id'];

It should read:
$display->css_id = $node->panels_node['css_id'];
(i.e. a missing 's')

World's smallest patch attached...

mleicester’s picture

mleicester commented
Status: Active » Needs review
gp.mazzola’s picture

gp.mazzola commented

Thank you ordinaryfool!
I manually edited the file adding the missing 's', and now it works! :)

Ciao,
GP

dellintosh’s picture

dellintosh commented
Status: Needs review » Reviewed & tested by the community

Applied and tested. Works great now. :)

dellintosh’s picture

dellintosh commented
Assigned: Unassigned » dellintosh

(missed this in previous post.)

sdboyer’s picture

sdboyer commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

phicarre’s picture

phicarre commented
Status: Closed (fixed) » Active

I have the patch.
With the "configure settings pane" I configure the node content, I put "toto" as CSS ID
In the style.css file of my theme I define "toto":

toto {
background-color: red;
}

But my pane is not red !!
What could be wrong ?

dellintosh’s picture

dellintosh commented

in your css you should be using the following for an ID definition:

#toto {
background:red;
}

(Make sure you aren't forgetting the '#', since that tells your browser that it's an ID and not an HTML tag.) Let us know if you are still having troubles. :)

phicarre’s picture

phicarre commented
Version: 5.x-2.0-rc1a » 6.x-2.0-alpha2

I corrected as you wrote: always trouble BUT I forgot to say I tried the 6x20-alpha2 and 6x2x-dev versions !

dellintosh’s picture

dellintosh commented
Version: 6.x-2.0-alpha2 » 5.x-2.0-rc1a

That was your problem. :) This patch was intended for the 5.x-2.0-rc1a, NOT 6.x.. :) I would recommend reverting to the unpatched versions, and if you are still having troubles, please start a NEW issue so we may track a fix for it instead.

Thank you,
-dellintosh.

dellintosh’s picture

dellintosh commented
Status: Active » Closed (fixed)

issue closed.

ronline’s picture

ronline commented

I’m having the same problem on Drupal6 with modules/panels/plugins/layouts/flexible/flexible.css .