When an acidfree album node is not a page of its own (i.e. the page parameter is not true), neither the "Start slideshow" link nor the RSS feed should be displayed. These nodes are not pages on their own when they are shown on the front page for example. In the current version, each album on the front page gets a link of its own (which means that the link is displayed five times when there are five album nodes on the front page). I suggest the following change:

// proposed piclens_acidfree.module
function piclens_acidfree_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
  if ($op == 'view' && $node->type == 'acidfree' && $a4 != false) {

instead of

// current piclens_acidfree.module
function piclens_acidfree_nodeapi(&$node, $op) {
  if ($op == 'view' && $node->type == 'acidfree') {

Works great for me :-) Any thoughts, comments, whatsoever?

Regards, Ingo

Comments

swentel’s picture

Funny bug, never thought about this :)
I should be able to commit it this evening, I'll let you know when it's happened!

swentel’s picture

Status: Active » Closed (fixed)

commited to drupal-5 branch, thanks for the report!

ingomueller.net’s picture

Cool! I'm working with drupal since sunday, so I'm really happy that I could already contribute something :-)