Using jquery_update 5.x-2.0-rc1 on D5.7
http://drupal.org/node/267976

On my test site, nice menus triggers an error in IE6 & IE7. My guess it's a bug with nice_menus/nice_menus.js Possibly a conflict with jquery 1.2.6? I'm tempted to rip that iframe code out.

http://www.nahbprods.com/test/

Comments

add1sun’s picture

add1sun commented
Title: Does nice menus work with jquery update w/jquery 1.2.6? » Support jquery 1.2.6 as well
Category: bug » feature

You can rip out the iframe code, just be aware that your nice menus will not work properly over form selects in IE6 if you do.

I haven't looked at what differences there might be with newer jQuery so if you find out what it is and can submit a patch that would be great. Keep in mind it is most important for me to support the jQuery that comes with core so a patch would need to work for both core jQuery as well as the newer versions you are targetting.

I'm moving this to a feature request since supporting other contrib/non-core code is a feature, not a bug.

add1sun’s picture

add1sun commented
Title: Support jquery 1.2.6 as well » Error in IE with jquery update
Status: Active » Postponed (maintainer needs more info)

There are new changes to all of the dev versions that reworked how the JS is included and removed the funky iFrame shim from IE 7 (only IE 6 really needs it).

The JS code itself is fine with jQuery 1.2.6 as far as I know. Please test the new dev versions and see if that helps.

jrabeemer’s picture

jrabeemer commented

Addi, I updated to dev on the site, and all the IE6 and IE7 JS bugs disappeared. No rollover bugs now. Using.. // $Id: nice_menus.js,v 1.5.2.9 2008/07/11 16:10:35 add1sun Exp $

add1sun’s picture

add1sun commented
Status: Postponed (maintainer needs more info) » Fixed

I'm going to mark this fixed.

Mark B’s picture

Mark B commented

Tested
// $Id: nice_menus.js,v 1.5.2.10 2008/08/04 23:46:09 add1sun Exp $
on Drupal 5.5 with jQuery v1.2.6, and seems to be working nicely - my IE javascript errors have disappeared. Nice work add1sun!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.