Drupal 6?

I'm currently working on porting this to 6. I'll post a first patch soon.

Here is a first patch for Drupal 6. It should be mostly complete.

Two areas that are questionable are as follows:

• Forum Icons: I'm not sure if this is working correctly as I have never really used the forums so I don't know exactly if the changes I made took effect. I would be happy to have someone else take a look and make sure.
• Comment Wrapper: This is not working. For some reason, I couldn't get the functionality to work. I was on the plane and no Internet access while I was working on it so I could be missing something obvious. I will pursue it more soon.

Please test it out.

Oh, the CSS patch to remove the HTTP requests has not been updated yet.

The patch doesn't appear to have the required blueprint.info file included...the attached patch adds this file, but other than that is identical to the patch above.

Oops! Not sure how I missed that one! Thanks for correcting it.

Hi designerbrent,
How's the update going? I attempted to use the patch today, but struck quite a few issues. I won't bore you with the details, if I'm working on old code here.
Cheers

lyricnz,

What were the issues you ran into? What version of the theme were you patching against? I have been using the theme for several sites since I created the patch and it has been working ok for me but I haven't done much to improve it.

However, if there are issues, I'd be happy to try and address them...

Okay, here we go, first issue - please consider I'm not a themer at all, and this is my first contact with Drupal 6 theming:

• I'm using totally stock Drupal 6.3, no modules installed; with blueprint-5.x-1.0.tar.gz with 'Blueprint 0.7.1.zip' and the patch from #4. Installed thusly:
  

  + rm -rf blueprint
  + tar xfz blueprint-5.x-1.0.tar.gz
  + unzip -q -d blueprint 'Blueprint 0.7.1.zip'
  + mv 'blueprint/Blueprint 0.7.1' blueprint/blueprint
  + patch -p1 -d blueprint
  patching file blueprint.info
  patching file page.tpl.php
  patching file README.txt
  patching file template.php
  

• first issue is that no blueprint CSS includes are emitted in the HTML. This appears to be because blueprint.info includes
  

  stylesheets[all][]   = ie6.css
  stylesheets[all][]   = ie.css
  stylesheets[all][]   = style.css
  stylesheets[all][]   = blueprint.css
  

  But the CSS are actually in ./css/ - and that's not how they should be used anyway (ie-specific stuff is directly in page.tpl.php, and this doesn't include blueprint css itself). I'll try and copy this back from D5 config, but maybe you can just upload your own blueprint.info, rather than the one above?

Ahh, yes, it works much better with:

stylesheets[screen, projection][]   = blueprint/blueprint/screen.css
stylesheets[screen, projection][]   = css/blueprint.css
stylesheets[screen, projection][]   = css/style.css
stylesheets[print][]               = blueprint/blueprint/print.css

Is there any reason the drupal_flush_all_caches() calls are still in page.tpl.php and template.php?

I guess I accedentally left the drupal_flush_all_caches() in. The only reason it is there is that it is helpful to have while adding tpl files. Otherwise Drupal will cache the core tpl's, ignoring any new ones you add in the theme folder. You can either flush the cache, or add that line to do it everytime page.tpl.php loads.

I'll try and look over the theme again in the next couple days.

subscribing

subscribing

Ok, I think this is a better patch. There are still a couple TODO items that I'm not sure how to trigger those conditions and I appreciate any guidance on those. However, this takes into account the problems noted above.

The patch works against the current blueprint-5.x.1.0 release.

Subscribing.

Has anyone gotten a chance to test this patch yet? It appears to be working for me but I'd love to get some other eyes on it.

It worked fine for me, with my very simple testing, but I've yet to produce a proper site with it (Yay D6, and decent sub-themes).

I wish I could roll a patch for this right now, but I'm at a coffee shop computer doing a little work before an afternoon wedding (not mine!).

In the D6 patch for blueprint, we need to make sure that css/style.css gets loaded last per blueprint.info. Otherwise, none of the rules specified in css/style.css to override the default blueprint.css rules work properly.

Otherwise, I can also confirm that this D6 patch seems to work as advertised. Thanks for the help!

Wow, this one sounds like a drupal dream, it would be nice if drupal had a starter theme as part of the core themes, one that is fully optimized like this.

Agree with #17 of course. That's the way my example did in #9, but the latest patch doesn't :)

Patch in #13 is working fairly well for me with the addition of the edit to blueprint.info in #9.

When I go to Administer > Themes I get this error:

Fatal error: Call to a member function getName() on a non-object in /home/drupal/sites/all/modules/devel/devel_themer.module on line 370

EDIT: I get this error on several administration menu options. Enabling an administration theme, such as Garland, before installing the devel module seems to be an effective work around.

Rerolled with suggestion from barneson in #17. I'm not sure that that will always work cause in some of my testing, it doesn't seem to be consistent but I moved style.css down none the less.

@pcwick: I'm not sure what the problem is on that. I have experienced the same thing but stopped used the devel_themer.module. I'll dig around and see what I can come up with.

@pcwick: This patch will fix the getName() bug in devel_themer.module. It was a problem with the phptemplate_form_element() function not being properly defined in the transition from 5 to 6.

Can anyone tell me the difference between blueprint and the zen theme, they both appear to optimize, which is better ?

Also does anyone have a complete patched module, I'm having difficulty understanding the patch,

That last patch appears to have a few incomplete function lines,

ie line 469 (breadcr

I get this error
Parse error: syntax error, unexpected ',' in /template.php on line 173

@darumaki: That patch file is correct. It is not something that runs on it's own but has to be applied to the code. (http://drupal.org/patch/apply)

zen and blueprint are the same in that they try and establish a solid base for building your theme on. I haven't actually used zen so I can't speak to specific on how zen works. Blueprint, on the other hand, is built on a standardized css framework for building pages. http://code.google.com/p/blueprintcss/ It has a build in grid system, a reset style sheet and a typography style sheet. Additionally for the Drupal theme, m3avrck has built in some SEO optimizations that improve the theme by adding meta tags, in addition to other tweaks.

wow just learned how to apply a patch via terminal on mac, all this time, I have been trying to do it manually, got the theme working now :)

The patch in #22 seems to be working well with some minimal testing. Its helpful to be able to use devel themer. I'll be working with Blueprint for 6.x over the next few days, and I'll report any additional issues I find. Thanks designerbrent for your contribution!

Thanks for this port.
Been using this patch on a dev site for a week now.
So far everything seems to be working fine.

I've been using this patch for a couple days and haven't experienced any issues. Thanks.

In light of this success and the testimony of others, I'm changing the status on this to "reviewed and tested by the community."

I'm also using this patch, and it works for me too. Good work!
I haven't tested the comments or the forums, though.

Actually, we need to add the following in phptemplate_preprocess_page() (in template.php):

  $vars['path'] = base_path() . path_to_theme() .'/';
  $vars['user'] = $user;

Without the path variable, we don't get the right paths for the IE CSS files in page.tpl.php.

The user variable is not used in page.tpl.php, but the D5 version of Blueprint adds it in case one wants to use it.

@David Lesieur Thanks for the note there. I totally missed that. The patch this time includes the changes you suggested.

When can we expect a final release for drupal 6?
I'm very fresh on Drupal so i'm kind of affraid to do all this patching and using beta's.

Thanks,

Dennis

Initial 6.x port committed: http://drupal.org/cvs?commit=136432

Thanks for the help guys. I modified what was there and will continue to post improvements. Look for the 6.x dev release (which is working) will have a final 1.0 release once everything is confirmed.

thanks m3avrck for the update to v6.
but i think the theme blueprint.info file is missing from the 1st release of 6.x dev

The info file is now committed. Should be added the next time it gets packaged.

http://drupal.org/cvs?commit=136507

cool designerbrent.. sorry that i addressed only to m3avrck but you have to be credited for the update of the v6.
thanks

ica: no problem. It's been fun and it's a great theme to work with! m3avrck has done a lot of great work on it.

yes, the initial credit belongs to m3avrck,

the other great thing about this and other few strong 'framework' themes like
-tripoli http://devkick.com/lab/tripoli/
boilerplate- a blueprint kick http://code.google.com/p/css-boilerplate/

that they have a clear code, logic and actively developed across.

@m3avrck: While reviewing the 6.x-1.x-dev release, I noticed that you changed all the phptemplate_ fuctions to blueprint_ with the exception of the preprocess functions. What is the purpose of doing that? Wouldn't it be better to leave them as phptemplate_ as it would be more generic for those who want to change the theme name as they customize it?