Named constants are much better to use than strings for this sort of thing.

CommentFileSizeAuthor
bootstrap_constants.patch5.94 KBdrumm

Comments

chx’s picture

chx commented

It's fine with me. drumm says that if you do make a typo with the named constant a useful error is more likely.

drumm’s picture

drumm
he/him
Location NY, US
commented

I am nearly finished preparing a patch to update.php, which has modified lines next to a line modified by this patch. I'd like this resolved first to avoid conflicts.

dries’s picture

dries commented

Committed to HEAD.

dries’s picture

dries commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
drumm’s picture

drumm
he/him
Location NY, US
commented
Version: » 4.6.0
Status: Fixed » Closed (fixed)