We noticed that the right sidebar functionality was not working correctly,
Attached is a patch which the correct functionality as well as some theming which allows the right sidebar to show level 4+

I think there may be a bigger discussion here around how the different templates are being applied to different menus - as we did it based on the drupal selection - and not based on the menus them selves ( which I believe is how wet is doing it )

Please let me know what you think and how we could possibly get something simliar in WET

CommentFileSizeAuthor
#5 wetkit_menu_sidebar_right-2.patch11.08 KBaastrong
wetkit_menu_sidebar_right_menu.patch10.08 KBaastrong
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aastrong created an issue. See original summary.

sylus’s picture

sylus CreditAttribution: sylus commented
Status: Active » Needs work

This looks good to me can you correct the css part of the patch so it is all minified? Else looks good!

aastrong’s picture

aastrong CreditAttribution: aastrong commented

Yah for sure, I'll upload a new patch shortly.
Thanks

sylus’s picture

sylus CreditAttribution: sylus commented

A few more points:

1) CSS should be minified
2) In your patch:

 -      'template' => 'megamenu_sidebar',
+      'template' => 'sidebar_nav_right',

You are calling a new template but that new template doesn't exist.

3) Lots of white space added in patch
4) I don't like this code can it be removed?:

  //fix menu when only one children item exist (lines 379-381)
  if ($element['#attributes']['class'][0] == 'first' && $element['#attributes']['class'][1] == 'last') {
    $output .= '</ul>';
  }
aastrong’s picture

aastrong CreditAttribution: aastrong commented
FileSize
wetkit_menu_sidebar_right-2.patch11.08 KB

Here is the new patch
I've compressed my CSS - I've added the new template - i've removed the un needed spaces - and removed that one line.

sylus’s picture

sylus CreditAttribution: sylus commented
Status: Needs work » Fixed

Committed and attributed, thx for the patch!!!

  • sylus committed d8c11b8 on 7.x-4.x authored by aastrong 
    Fixed WetKit Menu for Issue #2700677 by aastrong: Wetkit menu Right...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.