Hi,

I configured this module with success, great to see it's simple and effective, and usefull !

However, I would like to theme it in a complete different way because I find using table here is not very semantically correct and I found that a lot of the page is generated in a non theme function.

I could easily remove some div, hide some description etc... but the main table is not modifiable without hacking core.

It is possible to correct that ?

I will continue to look through the code

thanks

zmove

Comments

zmove’s picture

Title: Make taxonomy list more themable » Here is a patch
StatusFileSize
new49.16 KB

Pretty Easy to do, this is a patch that make _taxonomy_list_get_table themable. it allow the user to create something else than a table if he want.

I didn't touch it, but maybe if the user can do another thing than a table, maybe renaming the function is a good idea ;)

What's your opinion about this patch ?

zmove’s picture

Title: Make taxonomy list more themable » Here is a patch
Category: support » bug

double post

zmove’s picture

Title: Here is a patch » Make taxonomy list more themable
Category: bug » support
Status: Active » Needs review
StatusFileSize
new49.16 KB

Pretty Easy to do, this is a patch that make _taxonomy_list_get_table themable. it allow the user to create something else than a table if he want.

I didn't touch it, but maybe if the user can do another thing than a table, maybe renaming the function is a good idea ;)

What's your opinion about this patch ?

nancydru’s picture

Title: Here is a patch » Make taxonomy list more themable
Category: bug » support
Status: Needs review » Needs work

This is not really a patch, but a complete replacement. In order to make a "proper" patch, please use "diff" with the options "-u -p". It will be a much smaller file.

zmove’s picture

Hmm, I'm on winerge and I follow the handbook about it. I don't know where yo add "-u -p" on windows winmerge.

nancydru’s picture

Actually, I've never figured out how to get it to do the "-p" but the "-u" seems to happen automatically when it's called by CVS.

You can download a package called "diffutils" (http://sourceforge.net/project/shownotes.php?release_id=83227). It's not quite as easy to use as CVS/Winmerge, but it's not hard.

zmove’s picture

Ok thank you, I will take a look into it !

nancydru’s picture

Assigned: Unassigned » nancydru
Status: Needs work » Fixed

Fix committed on 6.x-1.x-dev only. Note that after downloading the code, you must disable and re-enable the module for the new theme function to be recognized.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.