Taxonomy terms are not getting added to keywords (+patch)

SteffenL - June 13, 2008 - 13:10

Project:	Nodewords
Version:	6.x-1.0-rc1
Component:	Code
Category:	support request
Priority:	normal
Assigned:	Unassigned
Status:	closed

  function nodewords_keywords_prepare($type, $ids, $value, $settings) {
     if ($type == 'node' && function_exists('taxonomy_node_get_terms') && count($ids) == 1) {
       if (node_access('view', node_load($ids[0]))) {
         foreach (taxonomy_node_get_terms($ids[0]) as $term) {

This should probably be something like:

  function nodewords_keywords_prepare($type, $ids, $value, $settings) {
    if ($type == 'node' && function_exists('taxonomy_node_get_terms') && count($ids) == 1) {
     $n = node_load($ids[0]);
     if (node_access('view', $n)) {
       foreach (taxonomy_node_get_terms($n) as $term) {

A patch that works for me is attached

Steffen

» Login or register to post comments

#1

Rob T - June 30, 2008 - 05:05

I made this modification, and the taxonomy keyword feature is working so far.

#2

jcfiala - July 11, 2008 - 15:13

Status:

active

» needs review

I've made the same modification, and the taxonomy keyword seems to work fine now. Included is a patch, as I don't see one attached to the ticket yet.

Attachment	Size
nodewords_taxonomy_keywords.patch	980 bytes

#3

vladimir.dolgopolov - September 2, 2008 - 06:46

The patch works well.
Just rerolled the pach ($n -> $node and some cleanup)

Attachment	Size
nodewords270193.patch	969 bytes

#4

c4gamerz - September 17, 2008 - 10:52

there is one more problem, keywords looks like fun,humour,drupal but there should be space between them like fun, humour, drupal like that! any fix for it?

#5

c4gamerz - September 19, 2008 - 06:46

okay i just fixed it with the help of a forum member

here is the code

<?php
// $Id: keywords.inc,v 1.1.4.3 2008/01/24 20:49:32 robrechtj Exp $

/**
 * @file
 * Support file for KEYWORDS meta tag.
 */

function nodewords_keywords_prepare($type, $ids, $value, $settings) {
  if ($type == 'node' && function_exists('taxonomy_node_get_terms') && count($ids) == 1) {
  $node = node_load($ids[0]);
    if (node_access('view', $node)) {
      foreach (taxonomy_node_get_terms($node) as $term) {
        if (in_array($term->vid, $settings['keywords_vids'])) {
           $value .= ', '. $term->name;
         }
      }
    }
  }
  $value .= ', '. $settings['global']['keywords'];
  $value = _nodewords_keywords_uniq($value);
  return $value;
}

function nodewords_keywords_form($type, $value, $settings) {
  return array(
    '#type' => 'textfield',
    '#title' => t('Keywords'),
    '#default_value' => $value,
    '#size' => 60,
    '#maxlength' => $settings['max_size'],
    '#description' => t('Enter a comma separated list of keywords for this page. Avoid duplication of words as this will lower your search engine ranking.'),
  );
}

/*
 * Uniq a string which is a seperated list to items, preserving
 * the order in which they appeared.
 */
function _nodewords_keywords_uniq($text, $max_items = 0, $seperator = ', ') {
  if (empty($text)) {
    return $text;
  }

  $items = array_map('trim', explode($seperator, $text));
  $uniq_values = array();
  $uniq_lowers = array();

  foreach ($items as $item) {
    $lower = strtolower($item);
    if (!in_array($lower, $uniq_lowers) && $lower != '') {
      $uniq_values[] = $item;
      $uniq_lowers[] = $lower;
    }
  }

  if ($max_items > 0) {
    $uniq_values = array_slice($uniq_values, 0, $max_items);
  }

  return implode($seperator, $uniq_values);
}