There is patch for locale.module. This patch change locale_block and output select box with languages instead of links.

CommentFileSizeAuthor
#5 locale_270226.patch2.33 KBdrewish
#2 locale2.patch1.62 KBgor
locale.patch2.3 KBgor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gor’s picture

gor CreditAttribution: gor commented

Also we needs locale.js

Drupal.SelectLocale = function() {

  $('#edit-submit-language').hide();

  $('#edit-language').change(function () {
     $('#edit-submit-language').click();
  })
}

if (Drupal.jsEnabled) {
  $(document).ready(Drupal.SelectLocale);
}
gor’s picture

gor CreditAttribution: gor commented
FileSize
locale2.patch1.62 KB

a little bug fix

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Version: 6.2 » 7.x-dev
Status: Reviewed & tested by the community » Needs review

Should this go into HEAD first, and then DRUPAL-6?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Title: A little path. » Language select form instead of links for local

More descriptive title

drewish’s picture

drewish CreditAttribution: drewish commented
FileSize
locale_270226.patch2.33 KB

made a few changes, if we store $links in the form we don't have to process them twice.

i think we should be using the new Drupal.behaviors pattern for the JS code... in any case i rolled the .js into the patch.

meba’s picture

meba CreditAttribution: meba commented

Why have form instead of links? I don't understand the use case.

- Having links is much more common than having a form.
- Having form doesn't give you immediate overview of what languages are available on the site. This is against usability.

drewish’s picture

drewish CreditAttribution: drewish commented

the use case is having more than a small number of languages, it eats up a ton of space. one site i worked on had 14 languages.

as for usability i disagree, you get a view of what languages are available as soon as you click the drop down. most people aren't switching the language multiple times, you do it once and then carry on with browsing. since it's used infrequently it shouldn't take up a bunch of space like 14 links would.

meba’s picture

meba CreditAttribution: meba commented

"click the drop down" - exactly. That's one extra step, the one particular that makes it less usable.

Anyway, I see your point. But I think that as soon as this gets committed, we start to have support requests on how to make this back to links...You can see 2-3 languages everywhere, 14 languages is really an extreme case i think.

This may have two solutions:
- Make it your own module
- Make two blocks. Links & Form and administrator can choose from.

I think that Gabor should see this - Gabor? :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Links allow people to add language icons (see http://drupal.org/project/languageicons), which are great visual queue for selecting languages. Dropdowns don't allow for this. Also, making the block a themable function, and then letting whoever modify it to select boxes or a scrolling bar or whatever they prefer. Being a feature change, this would definitely not go into Drupal 6.

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou CreditAttribution: lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

Status: Needs review » Needs work

The last submitted patch failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Component: locale.module » language system

Cleaning-up the "locale module" issue queue as per http://cyrve.com/criticals.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Version: 7.x-dev » 8.x-dev
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Version: 8.0.x-dev » 8.1.x-dev
Issue summary: View changes
Status: Needs work » Closed (won't fix)

Closing out due to inactivity, please re-open if anybody wants to pursue this.