Closed (fixed)
Project:
Panels
Version:
5.x-2.x-dev
Component:
Plugins - content types
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
13 Jun 2008 at 21:22 UTC
Updated:
27 Jun 2008 at 22:43 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwI tracked it down. The problem is in panels_show_pane(). Oddly, panels_get_pane_title() (which is where the content type's callback is invoked), was only getting called if the $content_type was empty. ;) I've restored the old behavior from when this used to work, and in my limited testing, it's working exactly as expected. Tracing through the code, it looks like this should handle all the right cases, even if the content type isn't there, or doesn't define a title callback, etc, etc. Plus, this is only the title bar on the pane itself, so if there's an error message up there from something not being defined, that seems utterly reasonable on an administrative page like this.
Comment #2
dwwUpon further review by sdboyer, he pointed out that we still might need a condition when $content_type is empty to fall back to the
$block->titletitle. However, neither of us can come up with a case where $content_type is empty. ;) So, I'm not sure if this is needed, and I can't confirm the 2nd code path, but it's closer to how it used to be (only the logic works now)... ;)Comment #3
sdboyer commentedGreat, committed. Thanks!
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.