Hi

Very good module of you. Though I have met a couple of issues while trying to use it:
1. The PicLens Views module only works for "Table View" or "List View" view types. It would be great if it could work with Teaser View view type.
2. I looked into PicLens Views module source and I see that it calls views_build_view() function with pager limit = 0.This means that if there're 10000 nodes returned by the view, then rss would contain all 10000 nodes. I guess would be a performance killer. I saw a description on PicLens site about paging implementation: http://www.piclens.com/lite/webmasterguide.php#pagination, I guess this would be a good feature to implement.

Regards,
telega

CommentFileSizeAuthor
#2 piclens_views.zip1.4 KBtelega

Comments

swentel’s picture

swentel commented
Title: PicLens Views issues » PicLens Views : support for teasers
Assigned: Unassigned » swentel
Category: support » task

Hi Telega,

Good remarks, I've changed the title of this issue and created another issue for the pagination, that's indeed something I'll have to implement! I'm not sure if I'll get it working for teasers, but I'll certainly look into it.

telega’s picture

telega commented
StatusFileSize
new piclens_views.zip1.4 KB

Hi

I have implemented PicLens teasers support for my project. I'm attaching the code, if you like to see it.
Two notes about the code:
1. Optimization: my code uses node_load() to load nodes with fields. Probably this can be skipped for table/list views and your approach used.
2. I added code to display site logo in PicLens:

  $theme_settings = variable_get('theme_settings', '');
  $output .= '<atom:icon>'.file_create_url($theme_settings['favicon_path']).'</atom:icon>';

I guess this code can be moved into main piclens.module file so that it's common for all mediaRSS feeds.

Regards,
telega

swentel’s picture

swentel commented

Funny, I was looking right now on how to implement this, I'll look at your code right away, thanks!

telega’s picture

telega commented

Correction: line
$output .= '<atom:link rel="previous" href="'.url($_GET['q'], 'page='.($page-1)).'"/>';
should be
if (page > 0) $output .= '<atom:link rel="previous" href="'.url($_GET['q'], 'page='.($page-1)).'"/>';
Or otherwise sql exception is generated.

swentel’s picture

swentel commented
Status: Active » Closed (fixed)

Support for teasers add to drupal 5 branch - it's a slightly different approach than yours, but got good inspiration from it though. Thank for the code! Pagination is also on it's way.