Closed (fixed)
Project:
Ubercart Addresses
Version:
5.x-1.0-rc2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 Jun 2008 at 21:46 UTC
Updated:
22 Jun 2008 at 15:32 UTC
The hook_user insert function does not correctly create default addresses as the $uid variable is not set.
The variable used should be $address->uid. (line 227).
I'll roll a patch some time in the next day or so.
Comments
Comment #1
freixas commentedThere have been some changes since RC2. Could you check out the 5.x-1.x-dev release and see if it still has a problem? The line you refer to is no longer there.
Comment #2
marcingy commentedJust had a look at head (cvs) and the code looks fine there however your development snapshot (27th May) still has the error.
Might be worth either updating the dev snapshot or having an new RC?
So this can be closed once a release of some form with the fix is available on this project page.
Comment #3
freixas commentedI tagged the latest code and released it as RC3.
I thought the dev snapshot was just an automatic build of the latest HEAD. Apparently not. So 5.x-1.x-dev is always supposed to point to the same chunk of code. But I don't want to use 5.x-2.x-dev until I release 1.0. I don't see other people using 5.x-1.1.x-dev (or 5.x-1.x.1-dev) ; most people just have 5.x-.1.x-dev. Anyway, I'm completely confused and just decided to release RC3. It looks like I'll keep going with the RC scheme until the bug rate drops.
Any advice appreciated.
Comment #4
marcingy commentedJust been having a look at the service project and we have it set up to generate snapshot releases. These automatically generate the dev versions. The issue may be being caused if you created an actual tag, as drupal CVS may then be unable to generate a snapshot.
Comment #5
freixas commentedHmmm....So are you saying that if I hadn't created the RC tags, I would have got automatically updating dev builds?
Any recommendation for a fix? I don't think I should delete the RC tags now. Or should I?
Comment #6
marcingy commentedI thought you meant that you created a dev tag?
Comment #7
freixas commentedFixed in 5.x-1.x-rc2.